Pay Now button of My Orders display.

The new Pay Now feature in customer My Orders listing looks good.

However there are 2 serious problems with the drop-down box,
Looking again at the paypal plugin, for example, found a couple of further issues (which I suppose could be irrelevant in amyn cases, but would be good to see fixed in the generic versions).

(a) It lists all payment methods defined in the payment table, including those which are disabled in the administration screen.

(b) It does not call the payment method onPaymentDisplay() function with the result that it displays all payment methods including those which are not valid in the context of the current order.

(c) Looking at the paypal onPaymentDisplay() function it does not check the enabled[/] flag.
This seems to be a generic problem of all the payment plug-ins.

The latest version of my own paypal plug-in onPaymentDisplay() function now looks like this (also showing call to my routine to check if paypal is compatible with selected shipping method):

function onPaymentDisplay(&$order,&$methods,&$usable_methods){
 if (!$this->isShippingValid(@$order->shipping)) return false;
 if (empty($order->total)) return false;
 if (empty($methods)) return false;

 $found = false;
 foreach($methods as $method){
   if($method->payment_type!='bf_paypal'){
    continue;
   }
   if (!$method->enabled) {
    continue;
   }
   if(empty($order->total)){
    continue;
   }
   if(!empty($method->payment_zone_namekey)){
    $zoneClass=hikashop::get('class.zone');
    $zones = $zoneClass->getOrderZones($order);
    if(!in_array($method->payment_zone_namekey,$zones)){
     continue;
    }
   }
   $currencyClass = hikashop::get('class.currency');
   $null=null;
   $currency_id = intval(@$order->total->prices[0]->price_currency_id);
   $currency = $currencyClass->getCurrencies($currency_id,$null);
   if(!empty($currency) && !in_array(@$currency[$currency_id]->currency_code,$this->accepted_currencies)){
    continue;
   }
   $usable_methods[$method->ordering]=$method;
   $found = true;
 }
 return $found;
}

function onPaymentSave(&$cart,&$rates,&$payment_id){
 $usable = array();
 if ($this->onPaymentDisplay($cart,$rates,$usable)) { 
  $payment_id = (int) $payment_id;
  foreach($usable as $usable_method){
   if($usable_method->payment_id==$payment_id){
    return $usable_method;
   }
  }
 }
 return false;
}

For (a) and (b) the Pay Now feature could be moved to the order display (shown when customer clicks order number).
Could be placed in the header next to the Print and Cancel buttons.
That way all the information about the particular order is to hand.

For now I will turn off the Payment of orders not paid immediately feature.

(c) Best to put enabled check in for completeness.

(d) Agreed, but including the if makes the code more readable and might be safer in the long term if some extra functionality gets added into that function.

Disabled payment methods also appear in the drop-down list of the Administration / Sales form.

Should function load() in types/plugins.php after line 69 do a check like this:

else if (empty($method->enabled)) continue;

Makes sense, but it is confusing.

For instance Moneybookers appears in my list, but are not using it, and may never.

Looks like if someone experiments with one of the payment methods (enabled it, changed config, disabled it) then it is always there.

If the payment method has never been touched then it does not appear.

Deleting the method from the payment table appears to solve the issue - but a less dangerous hide/display parameter would be preferred.

Just had a quick play with a shipping method I am not using.
Looks like the same hide/display feature would also be useful on the shipping methods.

When Pay Now button clicked in My Orders Shipping information $order->cart->shipping is missing in onAfterOrderConfirm() routine of payment plugin.

It is present during normal checkout.

In the payment plug-in I am using it to get:

$order->cart->shipping->shipping_name

$order->cart->shipping->shipping_price_with_tax

$order->cart->shipping->shipping_price

That works, thanks.