Product filters don't work with falsy values

-- HikaShop version -- : 2.3.4
-- Joomla version -- : 3.3.6

Product filters with falsy values are ignored.
Problem is in file \plugins\hikashop\massaction_product\massaction_product.php on line 60:

if(!empty($filter['value']) || (empty($filter['value']) && in_array($filter['operator'],array('IS NULL','IS NOT NULL')))){

!empty($filter['value'])

isset($filter['value'])

Hi,

Could you try that instead:

if((!empty($filter['value']) || $filter['value'] == '0' ) || (empty($filter['value']) && in_array($filter['operator'],array('IS NULL','IS NOT NULL')))){

This solve the issue for 0 but not for empty string ''.

Hi,

In which case do you want to let the field empty ?
In most of the filters, we can't allow an empty field, or you have to select "IS NULL" in the dropdown before that field.

IS NULL doesn't help because Hikashop use empty string when data are not provided.
I need it when I want to search for products not having filled alias, meta, title... etc.

You can use a filter like:
field_name = "NOT REGEXP" "[a-zA-Z]"

Which means that it will show all the product where the field "field_name" doesn't have any character.

I'm fine to use REGEXP ^\s*$ , but it's hard to persuade clients to dive in Regex.
My only concern is that user is allowed to save empty field and gets misleading results.

Hi,

You can potentially use your code, but I think that in some situations that can cause errors, not sure (there is a lot of possibilities).
Thanks to report us if any problems are met, if not we will do more tests with your suggested code and potentially use it in a future release if everything is ok.