Order Product List tax amount error

  • Posts: 292
  • Thank you received: 5
  • Hikashop Business
13 years 10 months ago #5302

I was getting a strange rounding error in the product list of the administration / sales / order screen.

Was not sure if it was something I had done, but after drilling through the stack I think it is due to line 21 in classes/order_product.php where the tax amount is being cast to an integer in method save().

','.(int)$product->order_product_tax.','
Removing the (int) cast appears to resolve the issue.

Please Log in or Create an account to join the conversation.

  • Posts: 82868
  • Thank you received: 13375
  • MODERATOR
13 years 10 months ago #5303

Thanks for the feedback.

We will fix that on our end as well. Actually, like for the price, you should use

$this->database->Quote($product->order_product_tax);
to be sure that you'll never get a SQL injection in the query.

Please Log in or Create an account to join the conversation.

Time to create page: 0.053 seconds
Powered by Kunena Forum