Carts are displayed instead of Wishlists

Joomla 2.5.
Hikashop 2.0.0


I had the wishlists and carts working properly and I'm not sure when ( we did 2 updates since then and installed Hikamarket ) they stopped working properly.

Currently, if I go to:

http://localhost/made/index.php?option=com_hikashop&ctrl=cart&task=showcarts&cart_type=wishlist&Itemid=512&lang=es

It will show CARTS, not WISHLISTS. --> Note that the cart_type var is specifying "wishlist".

I checked the code and, on line #279 of front_End../views/cart/view.html.php I see the following code.

                if(empty($cart_type)){
			if (is_object( $menu )) {
				$cart_type = $menu->params->get('cart_type');
				JRequest::setVar('cart_type',$cart_type);
			}
		}
		if(empty($cart_type)){
			$cart_type = JRequest::getString('cart_type','cart');
		}

                if(empty($cart_type)){
			$cart_type = JRequest::getString('cart_type','cart');
		}
                if(empty($cart_type)){
			if (is_object( $menu )) {
				$cart_type = $menu->params->get('cart_type');
				JRequest::setVar('cart_type',$cart_type);
			}
		}
		

Hi,

Thanks for the report.
You should better use this correction:

              if(empty($cart_type)){
			if (is_object( $menu ) && !empty($menu->params->get('cart_type'))) {
				$cart_type = $menu->params->get('cart_type');
				JRequest::setVar('cart_type',$cart_type);
			}else{
                                $cart_type = JRequest::getString('cart_type','cart');
                         }
		}

I tried it but it returns:

Fatal error: Can't use method return value in write context in ..components/com_hikashop/views/cart/view.html.php on line 281

Yes, my mistake.

              if(empty($cart_type)){
			if (is_object( $menu )) {
				$cart_type = $menu->params->get('cart_type');
                        }
                        if(!empty($cart_type){
				JRequest::setVar('cart_type',$cart_type);
			}else{
                                $cart_type = JRequest::getString('cart_type','cart');
                         }
		}

Hey, thanks a lot, I also used your fix (switching the order) and it worked. Please post if you encounter any bugs and I will do the same.

Bug encountered, when I click on the wishlist ID, it shows a blank list. Any Ideas?

It doesn't happen to me, I click on the ID / Name, and it takes me to the wishlist details.

I ended up using my code, not Xavier's because I didn't have time that day to wait for the fix, since it worked I didn't test Xavier's last suggestion.

What code are you using?

I used your idea, just switching stuff around. the Id not working is a bummer though....I hope an admin can help.

Have you tried my latest given code ?

I tried your latest code on line 279 and it's giving me a HTTP Error 500

Can you give me this 500 error ?

HTTP Error 500 (Internal Server Error): An unexpected condition was encountered while the server was attempting to fulfill the request.

this is how the code looks in the site:


$menu = $menus->getItem($Itemid);
}
}
if(empty($cart_type)){
if (is_object( $menu )) {
$cart_type = $menu->params->get('cart_type');
}
if(!empty($cart_type){
JRequest::setVar('cart_type',$cart_type);
}else{
$cart_type = JRequest::getString('cart_type','cart');
}
}
$pageInfo = new stdClass();
$pageInfo->filter = new stdClass();
$pageInfo

You have a syntax error, missing ")" on the second IF

Use this code: (Xavier's)

                    if(empty($cart_type)){
			if (is_object( $menu )) {
				$cart_type = $menu->params->get('cart_type');
			}
			if(!empty($cart_type)) { 
				JRequest::setVar('cart_type',$cart_type);
			}else{
				$cart_type = JRequest::getString('cart_type','cart');
			}
		}

Thanks, I added the code that was missing, but it's still not working for me.

The correction will be in the next release which should arrive soon.
Thanks to wait for it, and then tell us if the problem is solved.

Thanks. I will let you know.

I'm experiencing some of these problems as well. Wishlist list page shows cart list. Is there a solid fix/update for this?

ok, downloaded the todays latest version and seems to work fine now. Thanks.