Bug in shipping on checkout

Hi,

there seems to be a bug in the cart view (not the cart module)

The problem arises with two manual shipping configurations, and the second one being a free shipping (0EUR).
If someone has gone over the free shipping threshold and then goes back below the threshold using the product quantities, shipping costs are not displayed anymore.
Note, that the correct manual shipping configuration is chosen. The shipping cost is just not displayed.



Steps to reproduce:

In Administration:

1. Add a manual shipping configuration with any price, no filters
2. Add a manual shipping configuration with no price and a minimum price filter of 50 EUR

Now go to the front-end:

1. Put a product into the cart but stay below the 50 EUR threshold and goto checkout. The cart displays shipping information correctly after the sum.
2. Change the quantity of the cart, so that the sum passes the threshold of 50EUR. The cart now only dusplays the total, no shipping cost, which is ok.
3. Now change the quantity inside the cart so that you go below the threshold. Here's the BUG: The shipping configuration has changed to the first, correctly, but the shipping costs are not displayed.

Thanks,
Frank

Hi
I am already on the latest did update yesterday ... I am out of office right now but I think the latest was 2.1.2?

So I am back and I checked. I am on 2.1.2 and the problem is there.

This was a fresh download on 18-4-2013. Filename was: com_hikashop_business_2.1.2_2013-04-18.tar.gz
The download was triggered from inside Hikashop->Update/About.

BTW, Why should I re-download the same version? Unless it's essentially not the same version. Is the date inside the filename part of the version?

Reagrds,
Frank

So, I did a diff on the two versions and found differences in 16 files, and installed it.

Result: problem is still there. However I just noticed, while testing, that the problem has nothing to do with price thresholds. It actually happens all the time.

So I took the time to debug it a bit more and I finally found why this is happening.

In /components/com_hikashop/controllers/checkout.php around line 280 you do:

if(isset($_REQUEST['previous'])){

$this->before_shipping(true);

So, I fixed it in my installation.

in /components/com_hikashop/controllers/checkout.php around line 335 (in version 2.1.2-2013-04-20)
instead of:

} else if($this->previous == 0) {
    $auto_select_default = $config->get('auto_select_default',2);
    if($auto_select_default){
	$this->before_shipping(true);
	$this->before_payment(true);
    }
}

    $auto_select_default = $config->get('auto_select_default',2);
    if($auto_select_default){
        $this->before_shipping(true);
    }
} else if($this->previous == 0) {
    $auto_select_default = $config->get('auto_select_default',2);
    if($auto_select_default){
	$this->before_shipping(true);
	$this->before_payment(true);
    }
}

Thanks for your feed back .

Could you please let me know, when you guys fix it on your side, so I can stop re-applying my own hack?
Thanks

Sure all the changes will be showed through the changes log of next release of hikashop !

Hello,

After hours of trying to get it work, I still got the same problem as "thesilentman"

Whatever I try I don't get it.

I created two manual shipping methods

1. with a minimum of 1 and a maximum of 100 euro. The customer will charged for 5 euro
2. with a minimum of 100 euro. The customer will get a free shipment

The Hikashop version that I use, is Business v2.1.3
I also reapplied a new copy from my subscription, but this doesn’t solve my problem.

Can you please help me out?

Hi Nicolas,

Yes I tried the fix from "thesilentman" and that didn't work in my case.

I'm not exactly sure if my problem is 100% related to this issue.

The problem is that the manual shipping plugin not works in the way I think it should be.

I read a lot of topics in the forum, and it looks simple, but it doesn't work in my shop.

Do you have more information then the document on page http://www.hikashop.com/en/component/updateme/doc/page-shipping-manual-listing/component-hikashop.html

I attached a pdf file with my current configuration.


Thanks for the help.

Hi Nicolas,

I solved the issue

After hours of reading and trying the manual shipment plugin to work, I read a article in your FAQ that causes the problem.

"If you restricted your shipping method by price and kept the option "Include virtual product prices" to false on your shipping methods and that your products do not have a weight, the system might display an error message that no shipping methods were found even though the minimum price was reached because part of that price comes from virtual goods (with no weight). The solution is simple: either set a weight on your products or turn on the option "Include virtual product prices" in your shipping methods."

Thank you for your help and have a nice day.

Mohamed Thelji wrote: Sure all the changes will be showed through the changes log of next release of hikashop !