Vendor paid directly wrong Invoice for customer

Hi,

Vendor invoice number format
There is an issue for that specific point : the format.
If you take a look at the view "backend | vendormarket | options" you will see that the part for the invoice number format will set the value " {automatic_code} " if the setting is empty.
That is a mistake because each time that you will save a vendor in the backend, he will use the automatic format for the invoice and it won't use your HikaShop default configuration.
You can remove the two lines in the view and then empty that setting for your vendors.
And that issue will be fix in the next release.

Otherwise, HikaMarket respect the consecutive number without gap ; because the generated invoice id (and so, number) are consecutive value for each vendor.
That's why the "main order" is related to the shop (and customer) and why the "sub orders" are only related to vendors.
The first invoice that the vendor will create will be the invoice " 1 " because it is really his first invoice in that store.

The order number have the same logic but there is a setting to use the same main order number in the sub orders.
That setting exist to help the communication between the store, the customers and the vendor.

No Invoice should be generated in HS
Unfortunately, that's not true for every one, like you said, you're using the mode "vendor paid directly".
As you know, HikaMarket handle various modes ; in some of them the store is selling to the customer.
Like the mode where the vendor are paid directly but with a "collect on delivery" payment method and no vendor limitation in the cart. Even if that mode is strange, it is something which can be used (and that I saw).

If you want me to change the HikaMarket behavior, I need to be sure that it won't impact negatively existing store.
If you want a new setting for a specific purpose which will be benefit for you and other users ; I need to know the exact rules and conditions.

Regards,

Hi,

I wasn't talking programming...

1. You are selling as a shop ; you are "alone", you are not in a marketplace.
The transaction is between your customer and your shop and involve only the products in your shop.

2. If the vendor perform the transaction and all that the customer want to buy is sold by the vendor.
In the real life, you do not have the right to sell something which does not belong to you.

3. I do not understand the meaning of "tax".

Even in the real life ; the payment is regarding the customer and the content he wants to buy.
I already got your point of view but the problem is that is still do not understand mine.

The market mode (commission mode) "Vendor paid directly" is a mode of processing the commission, the fees.
You indicate in which way the fees should be process between your marketplace and your vendors.
Everything else in your HikaMarket configuration will really define if the vendor is paid directly or not.
I had to rename the market mode setting choices because users were doing all wrong and did not read the documentation to understand how they should configure their marketplace.

So, if you think that just the fact that the setting "vendor paid directly" is on should let the vendor provide an invoice directly to the customer. I'm sorry but you are currently wrong.

Regards,

But for now, if you want to display the "invoice id" from the subsale to the customer order ; you need to perform a view override.

In the view "front / order / show", you will see the code which display the invoice number

echo JText::_('INVOICE').':'.$this->element->order_invoice_number;

$order_invoice_number = $this->element->order_invoice_number;
$db = JFactory::getDBO();
$db->setQuery('SELECT order_invoice_number FROM '.hikashop_table('order').' WHERE order_type = '.$db->Quote('subsale').' AND order_parent_id = ' . $this->element->order_id . ' AND order_invoice_id > 0');
if(!HIKASHOP_J25)
	$invoice_numbers = $db->loadResultArray();
else
	$invoice_numbers = $db->loadColumn();
if( count($invoice_numbers) == 1)
	$order_invoice_number = reset($invoice_numbers);

echo JText::_('INVOICE').':'.$order_invoice_number;

Hi,

If you want the money be directly transferred from the customer to the vendor ; you have to use a payment method which do that.
Because the payment method (plugin) will be the element which will transfert the money to the final destination.

You can tell HikaMarket that your vendor are paid directly (so it will calculate the fee/commission), but if you're using a payment method which transfert the money directly into your bank account.. You will generate the issue.
That setting can't be magical ; that's why his original spelling was not that (but nobody understood it with correct accounting names...)

That is why you need :
1 - To limit your vendors in the cart ; so the transaction will be only between the customer and one single and unique vendor.
2.1 - To display only the vendor payment methods.
2.2 - OR to use "paypal adaptive" in "classical" mode so the plugin will use dynamically the vendor paypal email.

If you have several vendors in the cart ; The real life rule is that you can only pay one personne with one payment transaction.
Having X vendors to pay in the same time with one transaction, is not possible.
Like you cannot pay 2 people with one single coin. You'll give it to one of the two person and he will deal with the other one himself.

Vendors can sell directly (we get no money from customer for this deals and no Invoices should exist for that in HS)
Okay. So we assume that your market is right configure to let the customers pay directly the vendors.

You have to modify HikaShop to not generate the invoice id when it already have an invoice number.
Replacing

if(!empty($order->order_status) && empty($order->order_invoice_id) && empty($order->old->order_invoice_id) && $order_type == 'sale') {

$already_invoice_number = ((!empty($order->order_invoice_number) && !empty($order->order_invoice_created)) || (!empty($order->old->order_invoice_number) && !empty($order->old->order_invoice_created)));
if(!empty($order->order_status) && empty($order->order_invoice_id) && empty($order->old->order_invoice_id) && $order_type == 'sale' && !$already_invoice_number) {

Hi,

That's great but unfortunately that's not possible in HikaShop.
HikaShop is creating consecutive numbers ; which means that it looks for the higher current number in order to get the next one.
So you cannot have "groups" in HikaShop.

Regards,

Hi,

The idea behind the "invoice number format" per vendor is to allow a special formatting for your vendors.
So they can have a prefix number in they format.. But you can also use elements from the order object, like the "order_vendor_id" so it becomes generic (and dynamic).
That affect only the "invoice number" but it won't affect the invoice id ; which must start with "1" and follow a consecutive order without gap.

Regards,

Hi,

I'm sorry but I'm not following you anymore.

Regards,

Hi,

When you process the "vendor payment", it generates an entry in the HikaShop order table.
The order_type can be a "vendorpayment" or a "sale" depending the fee mode you're using (store paid directly / vendor paid directly).
To be more precise, when the store should send money to the vendor, the "order_type" is "vendorpayment".
But when the vendor need to pay the store, HikaMarket then use a "sale".

We use "sale" because it is easier for a lot of things. The vendor administrator can see the order in is listing and can pay it using a regular payment method available in the store.
It simplify a lot of things and if we use another order_type ; the order won't be visible in the customer side.

With HikaShop 3 and the new checkout system ; we can imagine that this payment part could be handle fully by HikaMarket which could use a special checkout workflow to let the vendors pay the store commission.
But for the moment ; it is clearly not something I will change or I'll recommend to change. It will break more thing that it could potentially solve.

Regards,

Hi,

1 - Already explained in the HikaShop configuration documentation.
www.hikashop.com/support/documentation/5...nfig.html#main_order

2 - I don't understand that question.

Regards,

Hi,

You (users) are lucky because you have to handle just one configuration of HikaMarket.
I got to handle several dozen of them in the same time ; dealing with modes which are totally opposite.
Please understand that I reply to a lot of messages every day (in the forum but also by email) and each message have a different context, a different configuration.

If you do not provide me your context clearly, it makes my task more difficult.
And more message there is in the thread ; more complicated it is to extract the current configuration (specially when that configuration can change and old message does not give the right information).

You just need to provide essential information.
1 - Market mode
2 - What you are doing

And then explain the issue.

Text in red or in bold does not help me much.
Explanation on the "why" could be useful sometimes but there is no need to concentrate on it.

To summarize your message in something I can understand in few seconds.

Market mode : vendors paid directly.
In the backend, we generate the vendor invoice for our commissions.

While HikaShop is configured with the invoice format " 1{id size="9"} ", the invoice number of that invoice is " C2 ".

if($vendor_id > 0) {
	if(!empty($order->order_status) && empty($order->order_invoice_id) && empty($order->old->order_invoice_id)) {

if($vendor_id > 0 && $order_type == 'subsale') {
	if(!empty($order->order_status) && empty($order->order_invoice_id) && empty($order->old->order_invoice_id)) {