Vendor Image Display Menu Item Does Not Inherit

  • Posts: 158
  • Thank you received: 6
9 years 2 days ago #221394

-- url of the page with the problem -- : artrageus1.com/members/
-- HikaShop version -- : 2.6.0
-- HikaMarket version -- : 1.6.6
-- Joomla version -- : 3.4.5
-- PHP version -- : 5.4.44
-- Browser(s) name and version -- : All

Hello,

I thought I would report that I set the image height and width for the vendor images/title in the configuration of the vendors section and set it to force. I then setup the menu item to point to vendors and asked it to inherit the image height settings. It ends up inheriting the image settings from Hikashop which was set at 500 pixels. In order to overcome this, I had to set the image settings in the menu item and click "Force" for it to set it according to my needs. I don't think you mean it to work this way.

Here's my settings from Hikamarket just in case I didn't get it right:



Best,

Dawn

Please Log in or Create an account to join the conversation.

  • Posts: 26158
  • Thank you received: 4028
  • MODERATOR
9 years 1 day ago #221396

Hi,

The "vendor image width" and "vendor image height" are only use for the HikaMarket vendor page.
You're right, in the vendor listing ; the "inherit" will use the default values from the HikaShop configuration ; so we can have some consistency between the product, category and vendor listings.

I am sorry, the HikaMarket configuration was not right for that part.
I fixed the configuration documentation page.
www.hikashop.com/support/documentation/1...#config_market_image
Sorry for the inconvenient.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 136
  • Thank you received: 7
8 years 1 month ago #250692

-- Joomla 3.6.2 --
-- HikaShop 2.6.3 --
-- HikaMarket 1.7.1 --

I find this a bit strange to. I would like to set the "vendor image width" and "vendor image height" to 1920px * 350px to get a nice big cover on Vendors page.
I think it is default 350*350 now, but when I try to change it and save, it keeps the settings. I have even tried to manually edit in database, but here I can only find 'vendor_image_y'. If I hard change this in database, it shows in back-end as 1980*1980.
Where is the 'vendor_image_x' value?

For the vendors listing page and products pages, as I understand it, I need to set image settings in HikaShop

Regards,
Henrik

.ninja { color: black; visibility: hidden; }
In case of fire:
1. git commit
2. git push
3. exit building

Please Log in or Create an account to join the conversation.

  • Posts: 26158
  • Thank you received: 4028
  • MODERATOR
8 years 1 month ago #250723

Hi,

You're right.
Please edit the backend view "configmarket / market" and replace the first occurrence of

<input type="text" name="config[vendor_image_y]" value="<?php echo $this->escape( @$this->config->get('vendor_image_y', '') ); ?>" /> px
By
<input type="text" name="config[vendor_image_x]" value="<?php echo $this->escape( @$this->config->get('vendor_image_x', '') ); ?>" /> px
We will add that patch in the next HikaMarket release.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 136
  • Thank you received: 7
8 years 1 month ago #250768

Hi
That did help on the save image. But there is still an other bug. I have to reverse it in back-end settings to get it to look right.
I would like to have width 1980 (x) and height 350 (y). But on the vendor page it shows in reverse. Height is 1980 and width is 350.
I can see on filename thumb is OK, but the cropped image is done in reverse.
Regards

.ninja { color: black; visibility: hidden; }
In case of fire:
1. git commit
2. git push
3. exit building
Last edit: 8 years 1 month ago by flexsus.

Please Log in or Create an account to join the conversation.

  • Posts: 26158
  • Thank you received: 4028
  • MODERATOR
8 years 1 month ago #250769

Hi,

Please check the modification you made in your configuration view so the option spelling will be affected with the right setting.
Y is for the height and X is for the width.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 136
  • Thank you received: 7
8 years 1 month ago #250787

I did check and settings is correct. Save is now OK, but it crops the thumb in reverse order.

.ninja { color: black; visibility: hidden; }
In case of fire:
1. git commit
2. git push
3. exit building
Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 26158
  • Thank you received: 4028
  • MODERATOR
8 years 1 month ago #250806

Hi,

In the file "components/com_hikamarket/views/vendormarket/view.html.php" please replace

	$image_size = array(
		$config->get('vendor_image_y', $shopConfig->get('product_image_y', 100)),
		$config->get('vendor_image_x', $shopConfig->get('product_image_x', 100))
	);
By
	$image_size = array(
		'y' => $config->get('vendor_image_y', $shopConfig->get('product_image_y', 100)),
		'x' => $config->get('vendor_image_x', $shopConfig->get('product_image_x', 100))
	);
Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 136
  • Thank you received: 7
8 years 1 month ago #250826

Thank you! That seems to crop the image to correct size.
But stiil, I don't get the result I expect.

In front-end as vendor I upload a new image of width 2978(x) X height 1418(y).
I have set Scale Mode to outside, but still gets white at left and right.
I tried to set Scale Mode to inside it makes no difference. And btw, when setting to Inside, the Radius is changed and set to '1'. You cannot change it to anything else. Radius is not working.
But anyways, the right settings in my case should be:
Vendor image with: 1980
Vendor image height: 350
Force size: Yes
Grayscale: No
Scale mode: Outside
Radius: 0

But it's not working.

.ninja { color: black; visibility: hidden; }
In case of fire:
1. git commit
2. git push
3. exit building

Please Log in or Create an account to join the conversation.

  • Posts: 26158
  • Thank you received: 4028
  • MODERATOR
8 years 1 month ago #250838

Hi,

HikaMarket is using the HikaShop image helper to generate the thumbnail.
You can see the all code in the view that you previously edit ; it generate an array for the "image options" and that array is used as parameter for the getThumbnail function.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 136
  • Thank you received: 7
8 years 1 month ago #250939

Hi Jerome
Thank you for your answer. But that answer does not quit help me. I’m not that good a programmer.
I need to understand if I have set something up wrong or if code is not working as supposed?
It seems to me that code is buggy here and you need to patch Hika Market. E.g. Radius is not saved and can only be set to ‘1’.

Let me re-explain what I would like with Vendor image.
I would like the Vendor image to be 1980 (width) X 350 (height).
If Vendor upload an image of e.g. 2048 (width) X 1024 (height), the image should be cropped and letting some parts of the image not visible.
If Vender upload an image of e.g. 512 (width) X 256 (height), the image “is cropped” and letting it have some white around image, since it is too small.
In my template design I will add a helper text for the Vender letting him know, that for the best result, he should choose an image of minimum 1980X350px.

An other thing I quit not understand is, does HikaShop settings: Main > Images >
Force size
Image scale mode
Influence on how Hika Market work? I mean, the same settings can be set here, in Hika Market?
Regards,
Henrik

.ninja { color: black; visibility: hidden; }
In case of fire:
1. git commit
2. git push
3. exit building

Please Log in or Create an account to join the conversation.

  • Posts: 26158
  • Thank you received: 4028
  • MODERATOR
8 years 1 month ago #250963

Hi,

Please update to HikaMarket 1.7.2 that we released today.
It will contains latest patches for the image settings.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.
The following user(s) said Thank You: flexsus

Please Log in or Create an account to join the conversation.

  • Posts: 136
  • Thank you received: 7
8 years 1 month ago #251012

Thank you!
That fixed the issues!

I still need to guide the Vendor to upload an image of best size (1920x350), but this is for sure better now when it's working as supposed.

.ninja { color: black; visibility: hidden; }
In case of fire:
1. git commit
2. git push
3. exit building
The following user(s) said Thank You: Jerome

Please Log in or Create an account to join the conversation.

Moderators: Obsidev
Time to create page: 0.085 seconds
Powered by Kunena Forum