Turning the variants on/off does not work well

  • Posts: 410
  • Thank you received: 9
  • Hikaserial Subscription Hikashop Business
2 years 6 months ago #341345

-- HikaShop version -- : 4.4.5
-- HikaMarket version -- : 4.4.0
-- Joomla version -- : 3.10.6

Hello,

we run into some problems when switching the variants on/off in the front-end.
If I disable 1 variant and click on save the variant, it works, but switching the next on or off does not work correctly. It only saves it when the product is saved. And if I click on a disabled variant, according to the switch it is already on?? Weird things are happening in the front-end editor :blink:

You can try it yourself... if you log in with the details below.

This message contains confidential information


Regards,
Michiel

Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 26156
  • Thank you received: 4028
  • MODERATOR
2 years 6 months ago #341360

Hello,

I cannot reproduce your issue in your website.
I can save the variants and the modifications are correctly stored in the database ; the changes are correctly displayed when switching the variants.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 410
  • Thank you received: 9
  • Hikaserial Subscription Hikashop Business
2 years 6 months ago #341391

Hi,

I've made you a video to see what is going on:

This message contains confidential information

I tried several different browsers.. all the same :dry:

Regards,
Michiel

Please Log in or Create an account to join the conversation.

  • Posts: 410
  • Thank you received: 9
  • Hikaserial Subscription Hikashop Business
2 years 6 months ago #341393

Try to turn on/off multiple variants... the first is working, after that it only works when you save the product

Please Log in or Create an account to join the conversation.

  • Posts: 26156
  • Thank you received: 4028
  • MODERATOR
2 years 6 months ago #341406

Hello,

There is a JavaScript error which is displayed multiple times

Uncaught ReferenceError: JoomlaCalendar is not defined
Which has been solved in HikaMarket 4.1.0 due to Joomla JS modification.
I recommend you to update to the latest version ; you're using HikaMarket 4.0.0 (and not the 4.4.0 which does not exist).

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 410
  • Thank you received: 9
  • Hikaserial Subscription Hikashop Business
2 years 6 months ago #341529

Hello Jerome,

I've updatet the test site we have, but still not working propperly.... it's the same as before: turn off or on 1e variant is working good, 2e variant off or on is not working/showing till you save the product.

This message contains confidential information

Regards,
Michiel

Please Log in or Create an account to join the conversation.

  • Posts: 26156
  • Thank you received: 4028
  • MODERATOR
2 years 6 months ago #341547

Hello,

Do you have a view override for the "productmarket / variant" view ?
Because the code is still not the one in the current release

if(typeof(JoomlaCalendar) !== "undefined" && JoomlaCalendar.init){
So there is still the JS error because you have the line
if(JoomlaCalendar && JoomlaCalendar.init){
Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 410
  • Thank you received: 9
  • Hikaserial Subscription Hikashop Business
2 years 6 months ago #341588

Hello Jerome,

Yes we have an override in this view.
We deleted the override and still it is not working.... so we changed the line "if(JoomlaCalendar && JoomlaCalendar.init){" to "if(typeof(JoomlaCalendar) !== "undefined" && JoomlaCalendar.init){" and it was still not working.

We made you a admin login to see and try for yourself

This message contains confidential information


please let us know what you did to get it to work so we can change it on the live site to.

regards,
michiel

Please Log in or Create an account to join the conversation.

  • Posts: 26156
  • Thank you received: 4028
  • MODERATOR
2 years 6 months ago #341613

Hello,

I made a test in your website (front-end) and I cannot reproduce your issue.
I'm able to change variant, edit the "published" state and same the variant which is updated dynamically in the section on top.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 410
  • Thank you received: 9
  • Hikaserial Subscription Hikashop Business
2 years 6 months ago #341641

Hello,

we tested everything in LambaTest ( www.lambdatest.com/ ) end saw that only in Safari the variants where turning on/off correctly.
In Chrome and Firefox it is still NOT working.... the first variant on/off is working ok, but after that nothing can be turned on/off until you save the product itself and return to the variants.

We have tried this now on 3 computers AND the independent systeem off lambdatest and still the same issue.
Hope you will trie again on some other browsers/computer?

Regards,
Michiel

Please Log in or Create an account to join the conversation.

  • Posts: 26156
  • Thank you received: 4028
  • MODERATOR
2 years 6 months ago #341687

Hello,

I was using Chrome with my previous tests. But I was able to see your issue with firefox.
The issue you have is the usage of a cache ; the product is updated correctly but the GET which is done in order to refresh the variant listing is returned by a cache.
We can try to force the request of the "no cache".
You can edit the file "components/com_hikamarket/controller/product.php" and replace (several times)

    if(hikaInput::get()->getCmd('tmpl', '') == 'component') {
By
    if(hikaInput::get()->getCmd('tmpl', '') == 'component') {
        hikamarket::headerNoCache();

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 410
  • Thank you received: 9
  • Hikaserial Subscription Hikashop Business
2 years 6 months ago #341757

Hello Jerome,

thanks for the solution! Works great ;)

Regards,
Michiel

The following user(s) said Thank You: Jerome

Please Log in or Create an account to join the conversation.

  • Posts: 26156
  • Thank you received: 4028
  • MODERATOR
2 years 6 months ago #341778

Hello,

Thank you for the feedback, I'm adding these patchs for the next release.

Kind regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

Moderators: Obsidev
Time to create page: 0.087 seconds
Powered by Kunena Forum