Rounding Errors

-- HikaShop version -- : 2.2.2
-- Joomla version -- : 3.2
-- PHP version -- : 5.3.3
-- Browser(s) name and version -- : N/A
-- Error-message(debug-mod must be tuned on) -- : N/A

There appears to be a rounding mismatch with the paypal payment rounding and hikashops rounding. In hikashop the tax ($2.9375) is rounded down to $2.93. When I have "Send details of the order" on in the paypal payment option the figure that is sent to paypal is rounded up to $2.94. The problem with this is because the payments don't match hikashop automatically cancels the order.

If you want to try to reproduce this the setup I have is as follows:

2 products $24.95 each
Shipping $8.75
+ 5% tax on everything

I turned the "calculations rounding" option on and it seems to have fixed the prices to match paypal.

The only problems I am having now are with the reports. When I try to do a sales report none of the prices are rounded. It just adds them all together and the final figure is quite far off from the actual amount of money collected. Is there any way to get the reports to round each transaction down (like it originally did when they were charged) or do I have to go into each individual order and change the amounts manually?

Also if you try to display a table with tax data (image attached) the following error is returned.

0 SQL=SELECT SUM(prod.order_product_tax*prod.order_product_quantity) as Total, a.order_currency_id FROM jos_hikashop_order AS a LEFT JOIN jos_hikashop_order_product AS prod ON a.order_id=prod.order_id AND prod.order_product_tax > 0 LEFT JOIN jos_hikashop_order_product AS prod ON a.order_id=prod.order_id WHERE a.order_type='sale' AND a.order_created > 1384020571 AND a.order_created < 1386612571 GROUP BY a.order_currency_id

Changed it and the error is now.

1066 Not unique table/alias: 'prod' SQL=SELECT SUM(prod.order_product_tax*prod.order_product_quantity) as Total, a.order_currency_id FROM jos_hikashop_order AS a LEFT JOIN jos_hikashop_order_product AS prod ON a.order_id=prod.order_id AND prod.order_product_tax > 0 LEFT JOIN jos_hikashop_order_product AS prod ON a.order_id=prod.order_id WHERE a.order_type='sale' AND a.order_created > 1384282128 AND a.order_created < 1386874128 GROUP BY a.order_currency_id

Hi,

Thanks to try to edit the file "administrator/components/com_hikashop/classes/widget.php" function "data()"

And add the code:

if(!isset($leftjoin['order_product']))

$leftjoin['order_product'] = ' LEFT JOIN '.hikashop_table('order_product').' AS prod ON prod.order_id = o.order_id ';

Added if(!isset($leftjoin)) in front of lines 620 and 634 but it didn't seem to change anything.
I probably just did it wrong as I know nothing about php.

Here is lines 616-623

if($setFilters){
			if(isset($widget->widget_params->filters['cat.category_id'])){
				if(($widget->widget_params->content=='customers' || $widget->widget_params->content=='partners')){
					$leftjoin['order'] = ' LEFT JOIN '.hikashop_table('order').' AS o ON o.order_id = a.user_id ';
					if(!isset($leftjoin['order_product']))$leftjoin['order_product'] = ' LEFT JOIN '.hikashop_table('order_product').' AS prod ON prod.order_id = o.order_id ';
				}else{
					if(!isset($leftjoin['order_product']))$leftjoin['order_product'] = ' LEFT JOIN '.hikashop_table('order_product').' AS prod ON prod.order_id = a.order_id ';
				}

if(isset($widget->widget_params->filters['prod.product_id'])){
				if(($widget->widget_params->content=='customers' || $widget->widget_params->content=='partners')){
					$leftjoin['order'] = ' LEFT JOIN '.hikashop_table('order').' AS o ON o.order_user_id = a.user_id ';
					if(!isset($leftjoin['order_product']))$leftjoin['order_product'] = ' LEFT JOIN '.hikashop_table('order_product').' AS prod ON prod.order_id = o.order_id ';
				}else{
					if(!isset($leftjoin['order_product']))$leftjoin['order_product'] = ' LEFT JOIN '.hikashop_table('order_product').' AS prod ON prod.order_id = a.order_id ';
				}
			}
		}

Hi,

Sorry for this very late reply.
Do you have solved the issue or found a way of doing what you want ?

If it is, sharing the solution could help the other users

I havent found a way to do this retroactivly but turning on "Round prices during calculations" under system>configuration>main>taxes seems to fix future orders