Report widgets and rows issues

-- url of the page with the problem -- : multiple
-- HikaShop version -- : 2.3.0
-- Joomla version -- : 3.3.0
-- PHP version -- : 5.4.27
-- Browser(s) name and version -- : all
-- Error-message(debug-mod must be tuned on) -- : Error_message

Reporting issues:

Creating a table, adding rows with for example total sales for this year. I select start date 1/1/2014, choose confirmed and shipped for status and leave everything else blank. This used to work but not anymore. It displays zero.
Even worse when I try to edit the row bij clicking the pencil, it opens as a new row with empty default title.

I also have had rows and even complete widgets dissapearing from the control panel.

Not sure if this is a bug or some sort of table issue but it is pretty consistant. I had it in J2.5 and now after the migration to J3.3 it is still there.

UPDATE: Just lost my table/widget for the third time: I was in edit mode, decide to cancel that and get out to the control panel and whole widget lost. DOuble checked this on other sites and the same happens.

I have made a long and detailed message in the contact form as request but did not hear anything back. Its about a week ago.
Can you confirm it is received and on someones 'todo' list?

Hi,

Sorry, we forgot to answer you.
Yes we have received the email via the contact form, and reproduced the issues.

I have added it on our TODO list and will correct it as soon as possible.

Guys, this is a major bug but we can't wait for a full new version. When can we expect a quick patch?

Hi there,

Sorry for the delay.
I quickly checked on our end and saw an issue.
Could you edit the file widget.php in administrator/components/com_hikashop/classes and replace this line:

$widget->widget_access=$formData['widget']['widget_access'];
$widget->widget_params->display='table';

$widget->widget_access=$formData['widget']['widget_access'];
$widget->widget_params = new stdClass();
$widget->widget_params->display='table';

Version 2.3.1, line 79. Replaced the code.
I don't get the extra lines/reports but the old ones are now overwriting the previous one.
EG, I create totals, last year and save it. Then create a new tabel row for totals this year and end up with only the last one with totals this year.

My bad, I might have done this a bit too quickly

the lines should be:

$widget->widget_access=$formData['widget']['widget_access'];
if(!isset($widget->widget_params)) $widget->widget_params = new stdClass();
$widget->widget_params->display='table';

Now I can add a (table row) with totals and they stay but the moment I want to edit them, I get a new report instead of the option to edit the existing one.

If the above issue gets fixed:
Still the other issues remains: when you create a report for "this year" you still get details from last year with it. I think Nicolas said it shows the last 365 days or so, which is not 'this year' . the same for other presets. At least I get very different numbers if I set the dates by hand, eg 1/1/2014-31/12/20014 compared to the 'this year' choice.

The widgets are extremely important for my clients. They want to see if their campagnes work or not.
Please pay some good attention to this. It has been left like this already for too long.

I check on your website and noticed Hikashop looks weird.

After setting the Joomla's "error reporting" option to maximum it looks like you have a x_cache issue which might cause a lot of bug. I disable the error reporting but if you could have a look at it it would be great.

From what I can see, some code seems to be removed. So your instalation of Hikashop might be defectuous. I would suggest to fix the x_cache issue (simply disable maybe), see if it fixes Hikashop and if not, reinstall it (if it's a live site create a copy). Your parameters and products should be conserved (but not the modification you made to the code so you'll have to re-add the code I gave you).

We're going to handle this

Hi Eliot, thanks for hanging on to this.

I maintain over a hundred Joomla sites and have seen this issue before at a few sites. The one thing in common is that they all where upgrade (step by step) from very early Hikashop versions. I assume somewhere in all those upgrades something could have gone wrong on a few sites. It would be interesting to find out what.
Of course I have re-installed Hika a few times before turning to the forum. The Jinstaller is not the most reliable piece...
For security did it again on this site today and re-adjusted the code.
As mentioned, I can make a new widget with a table. Editing does not work and when switching away from Hika and coming back, removes the new made widgets.

Since this is an active live site I can't switch on the error reporting now but I will make a copy of the website so we can test a bit better. (8GB so bit of a job)

I will be able to switch off caching for testing but not as a permanent solution. ( That site has days with 30.000 visitors)
This should also not be needed thats not a real solution. Errors need to be solved not 'hidden'

Test site has been setup with same FTP and credentials: test.v******.nl
xCache has been replaced by memcache but can be switched off for testing.
Hope to make some progress soon.

Hi Nicolas, thanks for picking this up. Apology accepted. I am going to calm down my clients with some nice totals.

Some feedback and checks:
Eliot wrote earlier and suggested to change some code, does your change comes on top of that or is just adding the $key good for all sites?

I have noticed that using "Last 30 days" shows all orders from the Egyptians up to now. Guess there is a bug in that one. Other settings seem ok as far as I can check now.

I have also notice that refunds, which my client books as negative orders, do not work well in the totals. They get added to the totals instead of subtracted.

Not sure what I wrote before but the issues we had:

Dashboard:
Widgets disappearing, fixed by Eliots code?
Creating tables in a report gave strange values. Most seems fixed but not all.
Editing tables made them jump and behave strange (the $key issue) fixed by Nicolas code
Totals with refunds are not calculated correctly.

Bastiaan

Hi Nicolas, sorry for joking With Egyptian's I was referring to a time before our years started counting.

1, YEs seems in the new release rthe widgets stay in place and got Eliots fix. After install I lost the most important widget (and a lot of work) but after I recreated everything it now seems to stay....

2. The issue is that some of the table rows data preselectors still don't work (and tested in the new release last night.)
It seems that at least the "Last 30 days" and "last year" options don't set the right dates internally. I am assuming the don't get the right start date set in the system and there show everything from the beginning instead of for example the last 30 days.

3. Yes thats how I did but bookkeepers want it differently btu lets continue the discussion in that thread.

Hope this is clear enough...

So what's seem to be left for the bug reports are the date preset option in the table reports.