« Quantity layout on product page » doesn't work

  • Posts: 263
  • Thank you received: 11
10 years 4 months ago #164064

Hello there,
I think that « Quantity layout on product page » doesn't work if applied on a category. It doesn't apply to products in the category.

If I change « Quantity layout on product page » in a product, it works.

Thanks

Hikashop 2.3.2
Joomla 3.3.0
HikaMarket Multivendor: 1.4.1

Please Log in or Create an account to join the conversation.

  • Posts: 263
  • Thank you received: 11
10 years 4 months ago #164067

I can have « Show left and right » works on my product page with :



It doesn't work with « show_inversed » layout enabled.



Thanks

Attachments:
Last edit: 10 years 4 months ago by Flooder.

Please Log in or Create an account to join the conversation.

  • Posts: 263
  • Thank you received: 11
10 years 4 months ago #164070

It doesn't work with this setup too :

Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 263
  • Thank you received: 11
10 years 4 months ago #164085

In the file components/com_hikashop/views/product/view.html.php

I changed

if(empty($productlayout)){
					if(!empty($category->category_layout) && $productDisplayType->check($category->category_layout, $app->getTemplate())) {
						$productlayout = $category->category_layout;
						break;
					}
				}

for
if(empty($productlayout)){
					if(!empty($category->category_layout) && $productDisplayType->check($category->category_layout, $app->getTemplate())) {
						$productlayout = $category->category_layout;
			//			break;
					}
				}

It works! But is it the best solution?

Please Log in or Create an account to join the conversation.

  • Posts: 26158
  • Thank you received: 4028
  • MODERATOR
10 years 4 months ago #164173

Hi,

I don't understand your patch. It means that you are taking the last category configuration instead of the first one.
How many categories does your product have ?
What's the configuration for the other categories of your product ?

Regards,


Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 263
  • Thank you received: 11
10 years 4 months ago #164186

For the patch, I only commented the « break » line...

Without my little patch, when editing a category, just try to select something else than « inherited » for the « product_layout ».

You will see, the selected « quantity layout » doesn't apply to the product page if you choose something else than « inherited » for the « product_layout ».

Attachments:
Last edit: 10 years 4 months ago by Flooder.

Please Log in or Create an account to join the conversation.

  • Posts: 26158
  • Thank you received: 4028
  • MODERATOR
10 years 4 months ago #164204

Hi,

I understood your modification but even if it allows the the quantity layout to be set, it is not the good solution.
In your case, it is working but in other cases, it won't.
I will rewrite the all algorithm, when the "quantity layout" has been added, it wasn't added in the right place for this algorithm.

Regards,


Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.
The following user(s) said Thank You: Flooder

Please Log in or Create an account to join the conversation.

  • Posts: 263
  • Thank you received: 11
10 years 4 months ago #164525

POur planification, cette situation sera-t-elle corrigée pour la version 2.3.2?

Nous mettons beaucoup d'effort pour la migration vers la migration du nouveau show_quantity.php. Sans la correction du fichier components/com_hikashop/views/product/view.html.php, c'est peine perdue pour nous.

Sans rancune, merci

Please Log in or Create an account to join the conversation.

  • Posts: 13201
  • Thank you received: 2322
10 years 4 months ago #164591

Bonjour,

Cette modification sera faite le plus tôt possible.
En attendant vous pouvez utiliser votre modification qui vous permet d'avoir le résultat que vous attendez.

Dès que vous mettrez à jour, cette modification sera automatiquement supprimée par la nouvelle.

The following user(s) said Thank You: Flooder

Please Log in or Create an account to join the conversation.

Time to create page: 0.102 seconds
Powered by Kunena Forum