2 little errors in filter.php

  • Posts: 18
  • Thank you received: 0
10 years 2 months ago #170010

-- Joomla version -- : 3.3.3

Found 2 things in filters module

In line 46 of filter.php you really don't print the main_div_name param.
Also, this is not an error but you never give the change of displaing the title of the module of the class sufix. You need to override the display to do that.

Thanks.

Please Log in or Create an account to join the conversation.

  • Posts: 26158
  • Thank you received: 4028
  • MODERATOR
10 years 2 months ago #170012

Hi,

Please provide your HikaShop version number and please provide more indication about which "filter.php" file.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 18
  • Thank you received: 0
10 years 2 months ago #170155

HI,

I'm in version 2.3.1, I now there is a new version but it still have these two things, there are not important, it was only for your information.

The filter.php I'm talking about is in /templates/MY_TAMPLATE/html/com_hikashop/product/filter.php

The automatic override when you edit the file form de hikashop display menu.

Please Log in or Create an account to join the conversation.

  • Posts: 26158
  • Thank you received: 4028
  • MODERATOR
10 years 2 months ago #170156

Hi,

Thanks for the precision and the information.
Because the "filter.php" changed in the version, the line "46" might be different or could have moved.
That's why it is important to know the precise version of the file (or having the line content). Just the line won't be precise enough to find the problem.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 18
  • Thank you received: 0
10 years 2 months ago #170269

Hi I update to the last version and it style got the same error,

The original file is: /fuden/components/com_hikashop/views/product/tmpl/filter.php

An echo is missing in line 46

Please Log in or Create an account to join the conversation.

  • Posts: 26158
  • Thank you received: 4028
  • MODERATOR
10 years 2 months ago #170277

Hi,

It will be fix in the next release.
I committed the patch.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

Time to create page: 0.052 seconds
Powered by Kunena Forum