GeoLocation with SET CURRENCY breaks gantry template homepage on first load!!!!

Hello,

Would it be possible to have more details about the issue ?
You gave us a link to the website home page ; but how can we see what is the error exactly ?
Do you have a page with the problem and another with the "normal design" ?

When you're using the geolocation plugin with the "set currency" feature, the plugin can load the HikaShop core in order to be able to load the HikaShop zone class and determine the user zone depending his IP address.
The plugin as HikaShop is general, is not compatible with "cache" because all the HikaShop content is entirely dynamic, starting from the customer cart, to the product "hit" counters, etc.

Regards,

Hello,

In one site, you have HikaShop 2.6.4 and in the other you have HikaShop 3.0.1
I can see that the page is not loaded as the homepage by your template but it is difficult to know why.
Except loading the HikaShop core, the plugin is not doing a lot ; it might store some information in the user session in order to select the current user zone of the user default currency (depending how you have configured the plugin).
The important thing to know is why your template don't load the homepage data even if it knows that the current menu item ID is 1033.

Regards,

Hi,

The difference between having that option on and that option off is that :
- HikaShop is loaded by the plugin -> that is done on all the pages where you have HikaShop, so if that was the problem you would have it on all the HikaShop pages of your website.
- the plugin contact the geolocation service to retrieve the information of the IP -> you can try changing the geolocation service in the settings of the plugin to see if it comes from the geolocation service being used.
- a few MySQL queries are run -> it can't come from that as otherwise you would have a big error message with an error message relative to the MySQL query.
- the currency is set in the user session for HikaShop to use it -> that can't be the problem and this works as otherwise, the problem would still be there if you refresh the page as it would try to get the currency again.

Also, the fact that the problem only occurs the first time means that the geolocation process went fine. And thus after that, the processing of the page continued and something else makes it not display the modules on your page.
The display of the modules depends from either your template or the loadposition system (based on how you configured them to be displayed). It's highly likely that it's your template.
So please understand that it's hard for us to tell you what to do because, as far as we understand the problem occurs after the process of the plugin and not in it, and thus in code that we didn't develop. Unfortunately, we cannot provide solutions for code that we don't know. The proper fix will probably be in the template since that the template which displays the modules, so my first recommendation would be to contact your template provider so that they can check on the issue.

PS: please also note that or support for HikaShop Business is only for valid subscription and your subscription has expired. You can renew it in the menu My account>My subscriptions.

Hi,

Saying that the issue is isolated to this plugin option is easy for them. I could say the same that I have isolated the issue to their template system, since it works in all the different and thousands of other templates for Joomla.
Saying that they can't guarantee the compatibility of their template with all the 3rd party components is easy too. We could also say that we can't guarantee the compatibility of HikaShop with all the 3rd party extensions.
Bottom line, the problem happens in the display of the modules in the template and we don't know how this is done on their end. It might be triggered by something that the plugin does, but since we don't know what and don't know where to look, we can't say anything. The fix is actually probably something to be changed in gantry/the template itself.

Even if we were to debug the problem in their template:
- we don't have the template and thus we can't reproduce the problem
- we don't know how the modules are being displayed by the template (in which line or which file of the template ?)
- they say that something is interferring with the routing, but as I described in my previous message, the plugin doesn't do anything with the router. What is changed in the router ?
The problem is not that we don't want to help, but we don't know how and they have the keys to be able to help, but they don't want to.

Alright, then add the code:
$app->redirect(hikashop_currentURL());
after the code:
$app->setUserState( HIKASHOP_COMPONENT.'.currency_id',$toSetCurrency);
in the file plugins/system/hikashopgeolocation/hikashopgeolocation.php
That will add an extra redirection after the currency is set.
That will circumvent the problem in the template since it only happens when the plugin is setting the currency.
But that's not the proper way to fix that and we can't add that on our end for everyone just because they don't want to look at the problem.

Hi,

So did you try the modification I talked about ?
Did that, at least temporarily solved the problem ?

I've posted an issue on their github as they requested:
github.com/gantry/gantry5/issues/1972
Feel free to add extra information you might have to help resolve the issue.

Hi,

An answer came back from gantry:
github.com/gantry/gantry5/issues/1972#issuecomment-298518052
Please follow the instructions there and report back your findings.
You can reply directly there, that will avoid the back and forth.

Hi,

Ok, then in the file of the plugin ( plugins/system/hikashopgeolocation/hikashopgeolocation.php ), change the line:
function onAfterInitialise(){
to:
function onAfterRoute(){
so that the geolocation is only done after the routing has been done be Joomla. That will prevent any possible conflict with it since the plugin will only be triggered after it.

Hi,

Thank you for your feedback. We'll add an option to the geolocation plugin in the next version of HikaShop so that you can choose to trigger it after the initialisation or after the routing.