Wrong behavior in the Checkout procedure

Hi,

In the Checkout tab of the HikaShop configuration you have a setting called "force menu on checkout". There, you can select a menu item to be used for the checkout.
If no menu item is selected there, I think it should stay on the current menu item.
If a menu item is selected there but it is invalid, the system will try to select a menu item of HikaShop randomly.
If a menu item is selected there and is valid, the system will use it on the checkout.

Similarly, when the cart is emptied, the system will use the "URL where to redirect when cart is empty" setting under the main tab of the HikaShop configuration to redirect where you want. If that setting is empty, it will select a random menu item of HikaShop to redirect to.

Hi,

I had already reproduced what you had described on your website. But I was not able to reproduce the issue on my local test website.
That's why I had concluded at an issue with that setting.
So today, I took another look. I actually noticed on your website that if I refresh the current page after I add the product to the cart, the checkout link's behavior is correct in the cart module.
And so, it means that the problem happens only when the cart module is being refreshed in AJAX and only with some menu item configuration.
So I looked further into it on my end and found that the problem would only happen with some menu items, not the one I was testing with.
Based on all of this, I found that the issue comes from the URL to refresh the cart module which is missing the current Itemid parameter. This leads to the system auto selecting a random menu item for the checkout link.
So I've made a patch to fix this. Since I was now able to reproduce the issue on my local website, I was able to confirm the patch fixes the problem for me.
Change the line:

window.hikashop.xRequest("<?php echo hikashop_completeLink('product&task=cart&module_id='.$module_id . '&module_type='.$this->cart_type, true, false, true); ?>", {update: el, mode:'POST', data:'return_url=<?php echo urlencode(base64_encode(hikashop_currentURL('return_url'))); ?>'}, function(xhr){

window.hikashop.xRequest("<?php echo hikashop_completeLink('product&task=cart&module_id='.$module_id . '&module_type='.$this->cart_type.$this->url_itemid, true, false, true); ?>", {update: el, mode:'POST', data:'return_url=<?php echo urlencode(base64_encode(hikashop_currentURL('return_url'))); ?>'}, function(xhr){