Hikashop user plugin form view is not well formed

  • Posts: 7
  • Thank you received: 1
10 years 10 months ago #140086

-- url of the page with the problem -- : www.sator.cz (Not accessible for public yet.)
-- HikaShop version -- : 2.2.3
-- Joomla version -- : 2.5.11
-- PHP version -- : 5.2.9
-- Browser(s) name and version -- : Google Chrome 30.0.1599.101 m
-- Error-message(debug-mod must be tuned on) -- : N/A

Here is source code of plugins/system/hikashopuser/hikashopuser.php starting on line 225 with highlighted bug. <dl> is not well formed. Depending on HIKASHOP_J30 only begin part of tag or end part of tag is generated.


if(HIKASHOP_J30){
$data .= '<fieldset class="hikashop_user_edit"><legend>'.JText::_('HIKASHOP_USER_DETAILS').'</legend><dl>';
}else{
$data .= '<fieldset class="hikashop_user_edit"><legend>'.JText::_('HIKASHOP_USER_DETAILS').'</legend>';
}
foreach($extraFields as $fieldName => $oneExtraField) {
if(HIKASHOP_J30){
$data .= '<div class="control-group"><div class="control-label"><label>'.$fieldsClass->getFieldName($oneExtraField).'</label></div><div class="controls">';
}else{
$data .= '<dt><label>'.$fieldsClass->getFieldName($oneExtraField).'</label></dt><dd>';
}
$onWhat='onchange';
if($oneExtraField->field_type=='radio')
$onWhat='onclick';
$data .= $fieldsClass->display($oneExtraField,@$user->$fieldName,'data[user]',false,' '.$onWhat.'="hikashopToggleFields(this.value,\''.$fieldName.'\',\'user\',0);"');
if(HIKASHOP_J30){
$data .= '</div></div>';
}else{
$data .= '</dd>';
}
}
if(HIKASHOP_J30){
$data .= '</fieldset>';
}else{
$data .= '</dl></fieldset>';
}

Last edit: 10 years 10 months ago by ropreoso.

Please Log in or Create an account to join the conversation.

  • Posts: 82864
  • Thank you received: 13372
  • MODERATOR
10 years 10 months ago #140146

Thanks for the report !

We'll add that fix in next version of HikaShop.

Please Log in or Create an account to join the conversation.

Time to create page: 0.055 seconds
Powered by Kunena Forum