Cart not updating anymore in plugin

Hello,

Yes that function is deprecated/obsolete for about a year now.
But you will find "addProduct" and "updateProduct" functions for that kind of job.
Don't hesitate to take a look at the HikaShop product controller to see how the "updatecart" function is working and handling the retro-compatibility.

Regards,

Hi,

You can do like that:

$class = hikashop_get('class.cart');
$cart_id = $class->getCurrentId();

// Check if cart total is larger than te plugin minimum price
if ($total > $product_min_price)
{
	// Add the free product
	$class->addProduct($cart_id, array('id' => $product_id, 'qty' => $quantity);
}
else
{
	// Remove the free product
	$class->updateProduct($cart_id, array('id' => $cart_product_id, 'qty' => 0 ));
}

Hi,

What do you mean by "when the quantity field is changed" ? This code will add a product with the id 128 with a quantity of 1 to the cart.
If you have it around some other code, it might be the rest of the code which doesn't work properly and call that code.
We would need more information on the situation and the code you have to provide a suggestion.

Hello,

I don't see any reference of "addProduct" in your code and as we said previously, the "update" function is obsolete.
And you can't use the function loadCart neither.

The trigger you're using, "onAfterCartProductsLoad" is not meant to do what you're trying to do.
It's a trigger which is called during the cart loading, just after the product are retrieved from the database. It is not safe to modify the cart content in the database while it's being loaded since the cart modification will invalid the cache and you can generate an infinite loop.

I rather recommend you to use other triggers, like "onAfterCheckCartQuantities" which allow you to remove/limit cart products.
And the trigger "onAfterCouponCheck" would be more appropriate since it's only called when there is a coupon in the cart which need to be check (called via the CartClass addCoupon function).

Afterwards, please understand that what you're asking is custom development.

Yes, we had to modify the Cart class and we had to remove that "update" function ; modifying a product during the loading of the cart was/is generating unwanted side effect since while the cart is being loaded, its content is being modified so the cart is directly invalid and need to be reload, once again (and you can create infinite loop with such behavior ; even in the old system).

Regards,

Hello,

but when you remove a feature from your API which breaks a plug-in like this

Hello,

After a small test, I admit that the trigger "onAfterCouponCheck" is not best.
It does not allow the cart product modification since the cart object would be used afterwards in the "save" of "addCoupon".
But if your developer had an issue with it ; he could say it so we would have made a patch proposal to use a partial cart object in the function "addCoupon".

Be sure that we are aware and open to suggestions for improvements.

Nevertheless, without using the trigger "onAfterCouponCheck", I was able to create a working plugin which extend the coupon capabilities and allow the user to select, in the backend, a product that he want to give for free when using the coupon.
Product which is added into the cart when the coupon is added ; product which is made "free" with a fixed quantity by the plugin and product which is removed automatically if the coupon is removed (or the coupon is removed if the free product is removed).

I know that I'm a HikaShop expert ; since I'm in the core team since 2012 and that I rewrote all the cart and the checkout systems for Hk3.
But it was not impossible.

Like I wrote :

It's a trigger which is called during the cart loading, just after the product are retrieved from the database. It is not safe to modify the cart content in the database while it's being loaded since the cart modification will invalid the cache and you can generate an infinite loop.

Hello,

I talked with Nicolas and we just released a plugin : "coupon free product".
www.hikashop.com/component/hikashop/prod...on-free-product.html

For the moment the plugin allow to add a product (for free) into the customer cart when using a coupon (cf my previous message).
Depending the feedback, that plugin could continue to evolve and provide other kind of features to extend the coupon capabilities.

And regarding of the feature to add a free product depending the cart total ; it's something which can be done using the "autoload coupon" feature of commercial editions of HikaShop.

Regards,