Troubles adter Upgrade from 3.4.3 Joomla to 3.4.4

  • Posts: 2293
  • Thank you received: 315
8 years 7 months ago #214139

-- HikaShop version -- : 2.5.0
-- Joomla version -- : 3.4.4
-- PHP version -- : 5.5.6
-- Browser(s) name and version -- : Mozilla

If I upgrading from 3.4.3 Joomla to 3.4.4 I have a bug in the "IMAGES AND FILES".
I can't delete images






the problem with iframe.php file

If I restore it from backup - it is ok.


Я не явлюсь официальной службой поддержки!
Я здесь добровольно!

Хочешь получить купон на скидку Hikashop? Спроси меня как!
Attachments:
Last edit: 8 years 7 months ago by progreccor.

Please Log in or Create an account to join the conversation.

  • Posts: 81504
  • Thank you received: 13062
  • MODERATOR
8 years 7 months ago #214144

Hi,

We don't have that problem on our end.
This indicates that there is a javascript error on the page. Open your browser's error console and look for the javascript error which appears for that page.
That should give more information in order to identify the problem.

Please Log in or Create an account to join the conversation.

  • Posts: 2293
  • Thank you received: 315
8 years 7 months ago #214210

I have tested many sites and see that the problem with all versions of hikashop - 2.4.3 and 2.5.0 - all versions have problem after upgrading Joomla from 3.4.3 to 3.4.4

I have feedback from 4 customers that have the same problems.

Try to install hikashop on 3.4.3 Joomla and after that upgrade to 3.4.4

Here is screenshots:





Я не явлюсь официальной службой поддержки!
Я здесь добровольно!

Хочешь получить купон на скидку Hikashop? Спроси меня как!
Attachments:
Last edit: 8 years 7 months ago by progreccor.

Please Log in or Create an account to join the conversation.

  • Posts: 2293
  • Thank you received: 315
8 years 7 months ago #214211

here is from another site

Я не явлюсь официальной службой поддержки!
Я здесь добровольно!

Хочешь получить купон на скидку Hikashop? Спроси меня как!
Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 2293
  • Thank you received: 315
8 years 7 months ago #214212

this is really big problem. On all sites appears this problem

Я не явлюсь официальной службой поддержки!
Я здесь добровольно!

Хочешь получить купон на скидку Hikashop? Спроси меня как!

Please Log in or Create an account to join the conversation.

  • Posts: 2293
  • Thank you received: 315
8 years 7 months ago #214216

I have noticed that the problem appears only if we use Russian language.
If we switch from Russian to English - all is working ok.

Could you help please?

Я не явлюсь официальной службой поддержки!
Я здесь добровольно!

Хочешь получить купон на скидку Hikashop? Спроси меня как!

Please Log in or Create an account to join the conversation.

  • Posts: 2293
  • Thank you received: 315
8 years 7 months ago #214218

I found the problem

Here is the trouble string:

Before:

ADD_TO_CART_HTML_CODE="HTML ссылка 'Добавить в корзину'"

After:
ADD_TO_CART_HTML_CODE="HTML ссылка - Добавить в корзину"

I think that problem was with apostrophe (') symbol.

So please change this line in Russian translation and it will fix the problem

Я не явлюсь официальной службой поддержки!
Я здесь добровольно!

Хочешь получить купон на скидку Hikashop? Спроси меня как!
Last edit: 8 years 7 months ago by progreccor.

Please Log in or Create an account to join the conversation.

  • Posts: 26000
  • Thank you received: 4004
  • MODERATOR
8 years 7 months ago #214229

Hi,

Thanks for the report.
We will see to "secure" the text in order to avoid the issues when the apostrophe is used. So even if someone change the translation to put that special character, it will not break the page.

So in the file "administrator/components/com_hikashop/views/product/view.html.php" you can replace (twice)

array('name' => 'popup','icon'=>'upload','alt'=>JText::_('ADD_TO_CART_HTML_CODE'),'url'=>$url),
By
array('name' => 'popup','icon'=>'upload','alt'=>JText::_('ADD_TO_CART_HTML_CODE', true),'url'=>$url),
It should activate the "jsSafe" from the Joomla Text, and avoid the javascript issue.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.
Last edit: 8 years 7 months ago by Jerome.

Please Log in or Create an account to join the conversation.

  • Posts: 26000
  • Thank you received: 4004
  • MODERATOR
8 years 7 months ago #214269

Hi,

File "layouts/joomla/modal/main.php", replace:

$script[] = "       modalBody.prepend('" . trim($iframeHtml) . "');";
By
$script[] = "       modalBody.prepend('" . str_replace("'", "\'", trim($iframeHtml)) . "');";

The patch from the previous post avoid the javascript error but display a backslash in the button content.... Which is not very nice.

Edit
Instead of that patch, please apply the official patch (which won't have side effect on dynamic URL).
github.com/joomla/joomla-cms/pull/7845/files

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.
Last edit: 8 years 7 months ago by nicolas.
The following user(s) said Thank You: handlyweb

Please Log in or Create an account to join the conversation.

  • Posts: 2293
  • Thank you received: 315
8 years 7 months ago #214271

Yes, I really think that the problem with the last update of Joomla. It is not the problem of the HIkashop, but it can be more safer to escape apostrophe symbols in that file.

The problem with /layouts/joomla/modal/iframe.php file

Need to see the changes from latest version of the file to understand what's wrong with it

Я не явлюсь официальной службой поддержки!
Я здесь добровольно!

Хочешь получить купон на скидку Hikashop? Спроси меня как!
Last edit: 8 years 7 months ago by progreccor.
The following user(s) said Thank You: romduf

Please Log in or Create an account to join the conversation.

  • Posts: 155
  • Thank you received: 4
8 years 7 months ago #214272

Hallo there.

I have the same problem after upgrading to joomla 3.4.4. All popups in the admin order mask are broken. Iìm working on italian language. I didn't apply your patches yet. should i do this ?

--- edit

also the invoice and the order confirmation bill are blank

Last edit: 8 years 7 months ago by Cattelan.

Please Log in or Create an account to join the conversation.

  • Posts: 81504
  • Thank you received: 13062
  • MODERATOR
8 years 7 months ago #214274

You should yes.

Please Log in or Create an account to join the conversation.

  • Posts: 155
  • Thank you received: 4
8 years 7 months ago #214275

I applied your patch. Isn't it a joomla core file ? what happens with further upgrades of joomla or Hikashop? Thanks for your reply

Please Log in or Create an account to join the conversation.

  • Posts: 81504
  • Thank you received: 13062
  • MODERATOR
8 years 7 months ago #214277

Note that the problem has been reported :
issues.joomla.org/tracker/joomla-cms/7890

The following user(s) said Thank You: progreccor

Please Log in or Create an account to join the conversation.

  • Posts: 2596
  • Thank you received: 62
  • Hikashop Business
8 years 4 months ago #223164

the problem is the same with a new installation (without upgrade) of Joomla 3.4.5 and Hikashop 2.6.0

Please Log in or Create an account to join the conversation.

  • Posts: 2293
  • Thank you received: 315
8 years 4 months ago #223169

please change in file /layouts/joomla/modal/iframe.php line 40

$iframeAttributes['name'] = $params['title'];
change to
$iframeAttributes['name'] = addslashes($params['title']);

Я не явлюсь официальной службой поддержки!
Я здесь добровольно!

Хочешь получить купон на скидку Hikashop? Спроси меня как!
The following user(s) said Thank You: erickb, Wtor22

Please Log in or Create an account to join the conversation.

  • Posts: 2596
  • Thank you received: 62
  • Hikashop Business
8 years 4 months ago #223170

it works thank you

Please Log in or Create an account to join the conversation.

Time to create page: 0.147 seconds
Powered by Kunena Forum