PHP 7.2 error "[] operator not supported for strings"

-- HikaShop version -- : 4.0.1
-- Joomla version -- : 3.9.0
-- PHP version -- : 7.2

Hi,

we tried updating our PHP version from 7.0 to 7.2, but we receive a fatal error "[] operator not supported for strings" on every product listing page where a product has variants, also with the latest Hikashop version 4.0.1 [1811151423] and with default protostar template.
The call stack indicates the error occurs in the administrator\components\com_hikashop\classes\currency.php file on line 956.

We haven't made any changes or customisations, but it seems slightly strange why no one else would have noticed this before. Thanks for looking into it and for any help.

Kind regards,

Hi,

ok, but clearly something is not working correctly and like I stated, we haven't made any customizations in any core files, in fact we just updated from 3.5.1 to 4.0.1 so all files are as delivered by the update. So what can we do to figure out what is causing this?

Kind regards,

Hi,

attached is a screenshot of the full call stack, hopefully it can provide some additional insight into the problem.
If we print the variant_ids they appear normal to us, for example: 220,221,222,223
However, if we print $products[$k]->variant_ids[] it appears the first element is null/empty and we think this is the cause of the error, because it falls through the check on line 954 since it is set, only null, and so on line 956 you assume it is an array while it is not, thus causing the error.

We have no idea so far why this first element is empty, and why strangely enough we seem to be the only one having this issue even though we don't have any customizations and use exactly the same code as everybody else, but if we change line 954 in currency.php from:

if(!isset($products[$k]->variant_ids))
      $products[$k]->variant_ids = array();

if(!isset($products[$k]->variant_ids) || $products[$k]->variant_ids==null)
      $products[$k]->variant_ids = array();

Ok, will this also be added on your end, or do we have to re-insert this code every time we update in future?

Thanks again.

That's great, yes Jerome's suggestion works fine, no more PHP errors anywhere.

I bought the Hikshop version 4.2.1 just a week ago, and I am facing issues on the product listing I made (I get a blank page with just the word "error" on the front end, when I display the debugging, it says: Error: [] operator not supported for strings: [] operator not supported for strings

Which is how came to this forum article.

If I still need to adapt something, can someone help me with precise instructions (which file to update in which directory and on which line?)
Thanks!!

The full context errors read:

With template jd_miami
Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; Color has a deprecated constructor in /home/xxxx/templates/jd_miami/features/color.php on line 11
Error: [] operator not supported for strings: [] operator not supported for strings

with template Beez3
Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /home/xxxx/administrator/components/com_seoboss/lib/Snoopy.class.php on line 651

The page is rendered as expected.


with template jd_fago
Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /home/xxxx/administrator/components/com_seoboss/lib/Snoopy.class.php on line 651

The page is rendered as expected.

Conclusion: use jd_fago on the hikashop menu items?

Thanks for pointing me in the right direction.