Email, per status override not working

Hi,

I was able to create a per status override with a status I first created in System>Order statuses.
I suppose it might be might to special characters in the namekey of the order statuses you created maybe ?
Could you provide more precise information on the situation ?
A screenshot of the settings of the status and your version of HikaShop, PHP, Joomla and your browser would be great.

Hi,

The namekey of the custom field will be used directly in the name of the override file where the modifications are stored.
We use Joomla's JFile::makeSafe function so it should strip special characters and work fine.
I did try on my end with a comma in the namekey and I didn't have a problem either. I used the order status namekey "Test , with , commas" and the modification of the HTML section worked fine in the "per status override" popup:
i.imgur.com/HPVvjQ2.png
And I got the file media\com_hikashop\mail\order_status_notification.testwithcommas.html.php created on my test website. As you can see, the makeSafe function stripped the commas and spaces and force the lowercase.

If you change the namekey in the database via PHPMyAdmin, you will have two problems:
- the order_status of the orders with that status won't match anymore. So you should also run a query to update the order_status in the hikashop_order table so that they are still linked
- the enable state in the different columns of the System>Order statuses menu will be lost for that order status. So you'll have to reset them there.
But as I said above, I didn't have the problem with a comma on my end so it's likely coming from something else.

Also, the last issue we fixed with the per status override dates from HikaShop 4.0.1 ( www.hikashop.com/forum/orders-management...ing-sent.html#304024 ) so if you have the 4.4.2, you already have all the fixes on that end.

You also said "latest Joomla". On your screenshot, it looks like Joomla 3.x, not Joomla 4.0 so I suppose that you meant the latest Joomla 3.x. Otherwise, I would recommend updating HikaShop as the 4.4.2 has many bugs on Joomla 4 that we already fixed in later versions of HikaShop.

Finally, I guess we'll need a backend access and a FTP access to directly check on the issue since we can't reproduce it on our end.
Please provide these via our contact form along with a link to this thread for reference:
www.hikashop.com/support/contact-us.html

Hi,

Thank you for the access.
I think I found and corrected the issue.
I changed the line:
$this->order_status = hikaInput::get()->getCmd('order_status', '');
to:
$this->order_status = hikaInput::get()->getString('order_status', '');
in the file administrator/components/com_hikashop/views/email/view.html.php
We'll add the change on our end too.
I'm actually not sure why I'm not able to reproduce the issue on my end as I should have the same issue as getCmd should have the same filtering on both our websites. But oh well, it's fixed

Hi,

The modification I gave is to be able to properly edit a "per status override" even with special characters.
It doesn't change anything to the sending of the emails.
So I'm not surprised if you found a new problem there.
I did some further investigation and there was a similar issue with special characters for the loading of the email when the email is being sent by HikaShop.
So I've added a second patch.
I've run a full test on your website and it seems to be working fine now.
We'll add that other patch on our end.

Hi,

The patches I made don't allow for that because this was already possible without the patches.
All the patches do is fix that capability when the order status being used includes special characters like a comma.

To do so, just click on the "per status override" button of the HTML section, select the order status for which you want to make your changes, change the HTML and save. Then rinse and repeat for each order status for which you want the email to be customized.