Installment Payments Bug/Enhancement

-- HikaShop version -- : 2.3.4

When using installments, the published flag is not being inspected when showing the payment methods.
We operate a festival and sell booth space to vendors. This event occurs in June. If you buy your booth in January, you get to make 5 payments (jan to may) If you buy in Feb, you get for payments (feb-may) up until May where you have to pay all at one time.
We would like to have separate installment options for each of those situations, and only allow selection of the appropriate number of installments for each scenario. If we set them up, they all appear, regardless of the published flag. Last year, we just change the number of installments, but that caused a lot of reporting and operational issues as all of the orders had the last number of installments.
If we could patch the code to only DISPLAY the published installment plans and the single payment options that would fit perfectly. The published flag should be ignored for PROCESSING payments because once created on and order, they should always processed.
A future enhancement to this might also be effectivety dates on the installments where they are valid between and including a starting and ending date.
Thanks in advance for your help,
Alan

Hi,

How do you have created many instance of the installment payment ?

Are you using the plugin "hikashop recurring" ?
If it is, it has not been ported to the multi instance.
That mean, that you should not be able to have many paypal recurring methods, but only one.

In you case, why not setting up one method with an installment on 5 months, and then edit it in february to set it to 4 installments ? At this time, when having only one paypal recurring instance set, the publish/unpublish feature is working fine.

the type is hikashop paypal recurring. I created 1, then copied it to a second with a different name, then changed the number of installments. When checking out both appear even though I unpublished the first.
The issue with the changing of the number of installments is that when you look at the orders, it has the same referential data as all the other orders, regardless of the number of installments...it only displays what is current. Last year it also did the last payments for orders that had the same method for multiple numbers of installments over time incorrectly and the client had to process the last payments for all the orders manually. Why would you have only one installment method? Couldn't you let people choose from 1-5 payments by having 5 of them? And if not, how do you account for different installment plans? I am really confused now.
Not sure what 'ported to the multi instance' means.
I don't haven issue with only having one published at a time...my issue is that during checkout it displays all of them regardless of whether I have them published or not.

I have duplicated this on the demo site. Payment methods AFM paypal recurring 1 and 2
Thanks,
Alan

Hi,

Please edit the file "plugins/hikashoppayment/paypalrecurring/paypalrecurring.php" and in the function "onPaymentDisplay()" replace:

				if($method->payment_type!='paypalrecurring' || !$method->enabled){
					continue;
				}

				if($method->payment_type!='paypalrecurring' || !$method->enabled || $method->payment_published == '0'){
					continue;
				}

As always, your fix is perfect and timely.
Thanks again for the tremendous support of your product.
Regards,
Alan

Hi,

Thanks for the feedback. It allow us to improve our component.