Payment with points is broken in 2.4

  • Posts: 53
  • Thank you received: 2
9 years 8 months ago #194317

-- HikaShop version -- : 2.4
-- Joomla version -- : 3.4
-- PHP version -- : 5.5.9
-- Browser(s) name and version -- : Firefox 36

Hello,

I want to upgrade our shop to 2.4 to use the newly implemented caching, but unfortunately there is some strange problem with the pay with points plugin. If the user has more points than necessary to pay for the current order, then the plugin tries to substract again a different sum after selecting the "Yes" option. I have attached 3 screenshots.

On the first one, when the customer doesn't have enough points to pay the total, the plugin works as expected. It substracts some value from the order and displays the result.



On the second one the customer has more points than necessary, and he has the option to pay with points for the current order ( he can not pay for the shipment ). The calculations are correct until this point.



On the third one however, after selecting the "Yes" option the plugin displays a different scenario for the same order, and also miscalculates the final total. It looks like the plugin adds the discount to the order and then offers a different amount of points to use. In our example before selecting the "Yes" option we had 940 points to use for 47 Ron, and after selecting the "Yes" option we have 1500 points for 75 Ron....



Any idea what's happening?

Regards,
Dezso

Attachments:
Last edit: 9 years 8 months ago by otx.

Please Log in or Create an account to join the conversation.

  • Posts: 26158
  • Thank you received: 4028
  • MODERATOR
9 years 8 months ago #194333

Hi,

Would it be possible to have more details about your "user points" payment plugin configuration ?

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 53
  • Thank you received: 2
9 years 8 months ago #194457

Dear Jerome,

Thank you for your reply. Here they are:








We have a separate domain for testing prior to upgrade the production site, let me know if you need access to this.

Please let me know if you have a solution, so we can start with the upgrade process. Thank you!

Regards,
Dezso

Attachments:
Last edit: 9 years 8 months ago by otx.

Please Log in or Create an account to join the conversation.

  • Posts: 26158
  • Thank you received: 4028
  • MODERATOR
9 years 8 months ago #194548

Hi,

I'm performing some new tests and I can't reproduce your exact issue but I found a potential issue which could be linked.
Can you please edit the plugin "plugins/hikashoppayment/userpoints/userpoints.php" and replace

		if(isset($order->additional['userpoints']) && $additional)
			$final_price -= $order->additional['userpoints']->price_value_with_tax;
By (to comment it)
		//if(isset($order->additional['userpoints']) && $additional)
		//	$final_price -= $order->additional['userpoints']->price_value_with_tax;
So the check of the additional userpoints won't be include in the processing of the final price.
It is the main modification made in the plugin between the two releases and even if the patch solve some things for some configurations, it looks like it requires a different test to just be use on specific cases.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.
The following user(s) said Thank You: otx

Please Log in or Create an account to join the conversation.

  • Posts: 53
  • Thank you received: 2
9 years 8 months ago #194608

Dear Jerome,

I tried your solution, and it does work. Thank you for your quick intervention!

Though there are almost all the time some issues with the point system when we want to upgrade our shop, is good to know that the support is ALWAYS on top to fix this as quick as possible. Thank you for your care and support toward us!

Regards,
Dezso

Please Log in or Create an account to join the conversation.

Time to create page: 0.098 seconds
Powered by Kunena Forum