V12 Finance Plugin

-- HikaShop version -- : 3.2.2
-- Joomla version -- : 3.6.4
-- PHP version -- : 7.0.29

Hi
Love the new checkout of Hikashop - much easier to configure and loads nicer for the user, desktop and mobile looking good!
However, we have one payment plugin written for V12 Finance (very popular in the UK) which doesn't like the final step in the new checkout stages. The data isn't being passed to the V12 url, for some reason. On legacy all is well.

So, regrettably I have to revert to Checkout legacy.

I've looked hard for similar issues and in the support documentation for the changes that might have broken the plugin, but have drawn a blank so far.
I realise it's beyond the scope of your support but if anyone has time to look at the plugin files (attached) it would be great to get it compatible with the new checkout.
I'm also happy to share the work we've done here as a new payment plugin, which might help others, though it probably needs some little development to make it a full package.
Attached, the plug-in files. Really hope you could take a look and point me in the right direction. The original developer has moved on but I have some skills and I'm keen to fix it.
Regards, Bob

Thanks for looking Nicolas
It actually has been working for over a year and we have had many sales this way.

The error message comes from v12_end.php:
'There was a problem with the application submission. Please contact us to manually create your order.'

In context:

// process the form
	jQuery('form#hikashop_v12_form').submit(function(event) {

		//Disable the submit button
		jQuery('#hikashop_v12_button').attr('disabled', 'disabled');

		// get the form data
		// there are many ways to get this data using jQuery (you can use the class or id also)
		var formData = {
			'product_id'      : jQuery('input[name="period"]:checked').val(),
			'deposit'     : jQuery('input[name=deposit]').val(),
			'data'    		: jQuery('input[name=data]').val()
		};

		// process the form
		jQuery.ajax({
			type        : 'post',
			url         : '?option=com_ajax&plugin=v12&format=json',
			data        : formData,
			dataType    : 'json',
			encode      : true
		}).done(function(data) {

			// log data to the console so we can see
			console.log(data);

			if (data.success) {
				if(data.data[0].formUrl) {
					jQuery('#application_link').attr("href", data.data[0].formUrl);

					//Hide the form and show the application link
					jQuery('#hikashop_v12_form').hide( "slow",function(){
						jQuery('#ajax-response-success').show("slow");
						//Click the link after 5 seconds
						setTimeout(function(){
							//Use window open as a click event will bind to the link before it has an href value
							window.open(data.data[0].formUrl);
						}, 5000);
					});

				} else if (data.data[0].noapplication) {
					//V12 didn't return an application link
					jQuery('#hikashop_v12_form').hide( "slow",function(){
						jQuery('#ajax-response-error').show("slow");
						jQuery('#ajax-error-message').html('There was a problem with the application submission. Please contact us to manually create your order.');
					});

...and more...

Ah, I see.
I will take a look at the files in the V12 folder within the Ajax Plugin. It's attached too, if you want to follow up - like I say, I think it would be a good addition to the Payment Methods of Hikashop, but needs a little more work - clearly, beyond my skills to make into a robust package.

Thanks again Nicolas

Thank you Nicolas - I've now got some quiet time to pick this up again (the bike business is quiet at this time of year). And it would be fantastic to use the new checkout, rather than the old legacy checkout which is not throwing the error.

Following your advice I can see the following error

"Undefined property: stdClass::$order_id in /home/juicebik/staging/6/plugins/hikashoppayment/v12/v12.php on line 170 "

which refers to this code:


$vars = array(
'CashPrice' => $amount,
'vLink' => $this->payment_params->vlink,
'DuplicateSalesReferenceMethod' => 'ShowOriginalApplication',
'SalesReference' => $order->cart->order_id,
);

Changing that to:

$vars = array(
'CashPrice' => $amount,
'vLink' => $this->payment_params->vlink,
'DuplicateSalesReferenceMethod' => 'ShowOriginalApplication',
/*'SalesReference' => $order->cart->order_id,*/
'SalesReference' => $this->order->order_id,
);

Seems to fix the issue and instantiate the SalesReference which was the issue shown in the console.

So, thanks for your detailed help once again and apologies for the delay in getting back to you.