When uploading a product picture, color problem

Hi,

What kind of picture are you uploading ? PNG ? GIF ?
HikaShop should resize the image and keep the transparency of the image, depending how the image has been encoded, it is possible that the PHP GD library can't handle correctly the alpha channel.
Knowing more about the image could help us (and you) to understand the problem.

Regards,

Hi,

Ok I see, you're using the "force size" option.
It is possible to change the background color in the parameters for the function getThumbnail of the HikaShop image helper.
In the file "administrator/components/com_hikashop/helpers/image.php" you will find the line

$bgcolor = $this->_getBackgroundColor($thumb, @$options['background']);

Hi,

Unfortunately, you'll have to do that change for each view file where the thumbnail is displayed.
So it could lead to a lot of changes: the product listings, the product page, the emails, the cart module, the cart view in the checkout, the cart details page, without even talking about the backend.
And each time the modification will be a bit different as the variable names are not necessarily the same.
To know which view file you want to change, you can activate the "Display view files" setting of the HikaShop configuration. That way, you'll be able to easily see which view file is used where (as it also depends on how your shop is configured I can't say for sure).
Then, you can edit them via the menu Display>Views.
I'll give you an example with the main image on the product details page. It's displayed with the code:

$image_options = array('default' => true,'forcesize'=>$this->config->get('image_force_size',true),'scale'=>$this->config->get('image_scale_mode','inside'));
		$img = $this->image->getThumbnail(@$image->file_path, array('width' => $width, 'height' => $height), $image_options);

$image_options = array('background'=> "#000000", 'default' => true,'forcesize'=>$this->config->get('image_force_size',true),'scale'=>$this->config->get('image_scale_mode','inside'));
		$img = $this->image->getThumbnail(@$image->file_path, array('width' => $width, 'height' => $height), $image_options);

Hi,

Having a transparent background is not an issue in most cases. HikaShop will keep the transparent background as long as the ratio of the image doesn't change.
So if you have the "force size" setting turned off, or if you have the "Image scale mode" setting set to "crop" of if you upload images with the same ratio that you configured in the thumbnails size settings, it won't have to add stripes around the tthumbnails and thus the color of the stripes won't matter as their won't be any.
Now that could still be an interesting setting to be able to define the stripes color. We'll think about that for a future improvement.

Hi,

Note that there is now a setting "Stripes color" in the HikaShop configuration to define the background color of thumbnails.
So you should not need to edit view files anymore.
And regarding the cart / checkout, while there is no view file which displays just the image, there is a view which displays the whole cart. It is displayed around the cart when you have the "Display view files" option enabled, and that's the view you would want to edit.
For example, for the cart on the checkout, it's the file "show_block_cart".
In there, you can find that code which displays the product thumbnails:

<td data-title="<?php echo JText::_('CART_PRODUCT_IMAGE'); ?>" class="hikashop_cart_product_image_value">
<?php
			$image = null;
			if(!empty($product->images)) {
				$image = reset($product->images);
				$this->imageHelper->checkSize($thumbnail_x, $thumbnail_y, $image);
			}

			if($image && !$this->config->get('thumbnail')) {
				echo '<img src="'.$this->imageHelper->uploadFolder_url . $image->file_path.'" alt="' . $image->file_name . '" style="margin-top:10px;margin-bottom:10px;display:inline-block;vertical-align:middle" />';
			} else {
?>
				<div class="hikashop_cart_product_image_thumb" ><?php
			$img = $this->imageHelper->getThumbnail(
				@$image->file_path,
				array(
					'width' => $thumbnail_x,
					'height' => $thumbnail_y
				),
				array(
					'default' => true,
					'forcesize' => $this->config->get('image_force_size', true),
					'scale' => $this->config->get('image_scale_mode', 'inside')
				)
			);
			if($img->success) {
				$attributes = '';
				if($img->external)
					$attributes = ' width="'.$img->req_width.'" height="'.$img->req_height.'"';
				echo '<img class="hikashop_product_checkout_cart_image" title="'.$this->escape(@$image->file_description).'" alt="'.$this->escape(@$image->file_name).'" src="'.$img->url.'"'.$attributes.'/>';
			}
				?></div>
<?php
		}
?>
			</td>