notrans not work for canonical

  • Posts: 2
  • Thank you received: 0
11 months 3 weeks ago #357840

-- HikaShop version -- : 5.0.2
-- Joomla version -- : 4.4.1
-- PHP version -- : 8.2.13

Hello, after updating to version 5.0.2, categories are translated twice by Canonical.

Therefore, if "#notrans#" is used, the "#notrans#" tag is removed in the first translation, and in the second translation, the phrase is translated.

First:
views/category/view.html.php

$element->category_canonical = hikashop_translate($element->category_canonical);

Second:
views/category/tmpl/listing.php
$canonicalUrl = hikashop_cleanURL(hikashop_translate($this->element->category_canonical));

Please Log in or Create an account to join the conversation.

  • Posts: 83007
  • Thank you received: 13399
  • MODERATOR
11 months 3 weeks ago #357844

Hi,

Thanks for your feedback.
This change was made following an issue we fixed here:
www.hikashop.com/forum/product-category-...l-urls.html?start=20
However, we over corrected for the categories listing as we made it consistant with the product view.

So, to keep the consistency with product / listing, we'll be replacing the line:
$canonicalUrl = hikashop_cleanURL(hikashop_translate($this->element->category_canonical));
to:
$canonicalUrl = hikashop_cleanURL($this->element->category_canonical);
in views/category/tmpl/listing.php for the next release.

The following user(s) said Thank You: Ebrahim

Please Log in or Create an account to join the conversation.

Time to create page: 0.055 seconds
Powered by Kunena Forum