FedEx Shipping - Destination Type Issue

-- HikaShop version -- : 2.4.0
-- Joomla version -- : 3.4.1
-- PHP version -- : 5.4.39

I have the FedEx destination type set to Auto-determination, so I would expect that it would show the rates only appropriate for the customer's shipping address (commercial or residential). No matter the type of the customer's address, I see all FedEx shipping options. With a commercial address, I should not see the Ground (Home Delivery) rate. With a residential address, I should not see the regular Ground option (which is cheaper). It should be the Ground (Home Delivery) option.

Edit:
I would also like clarification on how the determination between commercial and residential address works.

Hello,

1.
Sorry, on the version that I gave you on our previous thread I accidentally replaced the name of the ETA format option, to Destination Type, here is the last FedEx version.

2.

I would also like clarification on how the determination between commercial and residential address works.

Looking into the code in that latest update, the destination type setting currently has no effect, as that section of code is commented out. If it wasn't commented out and destination type is set to auto, then it uses the address_company field to determine if it is residential or not. Well, such a determination is problematic. Just because a customer enters a company name, doesn't mean that it is a commercial address. If it is a home-based business, like my own, then it should not get the commercial rate.

/*$data['destType']='';
		if(@$rate->shipping_params->destination_type=='res'){
			$data['destType']='<ResidentialAddressIndicator/>';
		}
		if(@$rate->shipping_params->destination_type=='auto' && !isset($order->shipping_address->address_company)){
			$data['destType']='<ResidentialAddressIndicator/>';
		}*/

I've made some changes to the fedex.php file to fix these problems. It also sorts the delivery methods in ascending order by rate. My changes are annotated by my username. For this, I did add a new address field that I called "address_type" with a single dropdown. The customer must select if the address is commercial or residential. This is used instead of the address_company field, for the reasons stated previously.

I still have the issue that I reported in another thread of the cheapest shipping option, among the shipping plugins being used, is not being selected.

Edit: I did add a sort function at the end of the file, that I forgot to annotate. I copied that from the USPS plugin.

Hello,
The FedEx code that you showed me was the old way to define the Residential parameter, here is the code which is setting that parameter :

if(@$rate->shipping_params->destination_type=='res'){
	$recipient['Address']['Residential'] = true;
}
if(@$rate->shipping_params->destination_type=='com' || (@$rate->shipping_params->destination_type=='auto' && $v == 'FEDEX_GROUND')){
	$recipient['Address']['Residential'] = false;
}

Mohamed Thelji wrote: Hello,
The FedEx code that you showed me was the old way to define the Residential parameter, here is the code which is setting that parameter :

if(@$rate->shipping_params->destination_type=='res'){
	$recipient['Address']['Residential'] = true;
}
if(@$rate->shipping_params->destination_type=='com' || (@$rate->shipping_params->destination_type=='auto' && $v == 'FEDEX_GROUND')){
	$recipient['Address']['Residential'] = false;
}

I just upgraded our test site to 2.5.0 and am still having several issues with this plugin.

1) Both FedEx Ground (Home Delivery) and FedEx Ground rates are being shown. FedEx Ground (Home Delivery) rates should only be displayed to residential delivery addresses. FedEx Ground rates should only be shown to commercial delivery addresses. A residential customer will, of course, select the cheaper of the two, which is FedEx Ground, even though they are not eligible for that rate. Maybe this situation is why I am seeing "The FedEx request failed with the message : Customer not eligible for service." error message.

2) I still get "The FedEx request failed with the message : Service is not allowed." error messages.

3) Delivery options are not sorted by rate.

I would recommend that you take a look at the changes that I made to the plugin, which is attached, as it addresses all of these issues. All of my changes are annotated.

If need be, I can give you access to our test site for troubleshooting purposes.

Hello,
1.
In that case the solution will probably be to add that kind of code :

if($v == 'GROUND_HOME_DELIVERY' && !$recipient['Address']['Residential'])
	continue;

if(@$rate->shipping_params->destination_type=='res'){
	$recipient['Address']['Residential'] = true;
}
if(@$rate->shipping_params->destination_type=='com' || (@$rate->shipping_params->destination_type=='auto' && $v == 'FEDEX_GROUND')){
	$recipient['Address']['Residential'] = false;
}

Mohamed Thelji wrote: 1.
In that case the solution will probably be to add that kind of code :

if($v == 'GROUND_HOME_DELIVERY' && !$recipient['Address']['Residential'])
	continue;

Just after these lines :

if(@$rate->shipping_params->destination_type=='res'){
	$recipient['Address']['Residential'] = true;
}
if(@$rate->shipping_params->destination_type=='com' || (@$rate->shipping_params->destination_type=='auto' && $v == 'FEDEX_GROUND')){
	$recipient['Address']['Residential'] = false;
}

Mohamed Thelji wrote: 2.
That issue is coming from the fact that some shipping services aren't compatible/available with your current FedEx shipping configuration/shipping address/.. to solve it and to use every services, you'll have to create multiple FedEx shipping methods with different configurations for each cases.

if(!$notif && !empty($response->Notifications->Message) && $response->Notifications->Message != 'Service is not allowed') {
	$app = JFactory::getApplication();
	$app->enqueueMessage('The FedEx request failed with the message : ' . $response->Notifications->Message);
}

if(!$notif && !empty($response->Notifications->Message) && strpos($response->Notifications->Message, 'not allowed') === false && strpos($response->Notifications->Message, 'not eligible') === false) {
	$app = JFactory::getApplication();
	$app->enqueueMessage('The FedEx request failed with the message : ' . $response->Notifications->Message);
}

Mohamed Thelji wrote: 3.
There is actually no option to do that but, sorting FedEx shipping rates will be easy to do by sorting the "$shipment" variable through the "_FEDEXrequestMethods" function.

Hello,
1.

From looking at the UPS plugin (line 527), it uses the address_company field to help in determining if an address is residential or not. There are problems with using that field, which I mentioned earlier, but at least that plugin tries to make that determination. So, why can't the FedEx plugin be changed to do so?

Mohamed Thelji wrote: 1.
As I already told you the FedEx shipping method wasn't originally developed by us, and I'm just maintaining it, but you're totally right, the address type determination should be based on the "address_company" !

Mohamed Thelji wrote: 2.
I know but some services are not compatible for example with the way you have the the "Packaging type" option for example, so the easier way will be to create different instance of that shipping method.

Mohamed Thelji wrote: 3.
Ok I just added it on the TODO list regarding the FedEx shipping method .

Hello,
1.
That option was already developed by a third party developer, but the best case for us will be to use the "address_company" field like we have done on the UPS shipping plugin.
The "address_company" is a default address custom field, we don't want customers to be forced to create a new custom field to use that shipping plugin.
2.
Some shipping configurations are compatible with some shipping destination/order weight/... and some are not, so you can use the FedEx option restriction to restrict that shipping method to only be used during "compatible cases".

Mohamed Thelji wrote: 1.
That option was already developed by a third party developer, but the best case for us will be to use the "address_company" field like we have done on the UPS shipping plugin.
The "address_company" is a default address custom field, we don't want customers to be forced to create a new custom field to use that shipping plugin.

Mohamed Thelji wrote: 2.
Some shipping configurations are compatible with some shipping destination/order weight/... and some are not, so you can use the FedEx option restriction to restrict that shipping method to only be used during "compatible cases".

Ok then I'll also add it on our Todo list an try to error messages.

it would be hard to do so. As far as I know, adding a restriction will affect all shipping methods,