FedEx shipping - Multiple package issue

-- HikaShop version -- : 2.6.1
-- Joomla version -- : 3.4.4
-- PHP version -- : 5.5.32

I'm working on some custom coding of the HikaShop FedEx shipping plugin. I'm working on shipping multiple packages in one order, but getting lower than expected shipping costs from FedEx compared to their online rate estimates.

Specifically I've found the code in the addPackageLineItem method in the fedex.php file seems to have an issue. The code in this function is not customized or modified. But it is not handling multiple packages. Please note I'm not familiar with nor do I have a copy of the FedEx shipping rate API documentation. However, that's my next step.

First, it starts by setting $packageLineItem[] = array();
Then a foreach loop breaks the $pkg_values passed parameter into individual $pkg items and sets up the contents of the array that will be added for each line item.
Then it sets $packageLineItem = array(...); This has the effect of redefining that variable rather than adding to it such that $packageLineItem is always the last item in the foreach loop rather than adding each new formatted array to $packageLineItem.

So the addPackage method never returns more than one package line item and always returns only the last item when multiple packages are submitted.

It seems the solution is to add each new formatted array to the $packageLineItem. I've done this as a test, but I'm not getting any response from FedEx. Since I don't know the format FedEx is expecting for multiple packages in one rate request my testing may not be building the correct array of arrays.

Anyone else noticed this and have a solution?

Hello,

You're right, the solution will be to change these lines :

$ct = count($pkg_values);
$x = 1;
foreach($pkg_values as $pkg) {
	if($pkg['PackageWeight']['UnitOfMeasurement']['Code'] == "LBS"){
		$uom = "LB";
	} else {
		$uom = $pkg["PackageWeight"]["UnitOfMeasurement"]['Code'];
	}
	if(is_array($pkg['Dimensions'])){
		$dimensions = array("Dimensions"=>array(
			'Length' => $pkg['Dimensions']['Length'],
			'Width' => $pkg['Dimensions']['Width'],
			'Height' => $pkg['Dimensions']['Height'],
			'Units' => $pkg['Dimensions']['UnitOfMeasurement']['Code'])
		);
	}

	$packageLineItem = array(
		'SequenceNumber'=>$x,
		'GroupPackageCount'=>$ct,
		'Weight' => array(
			'Value' => $pkg['PackageWeight']['Weight'],
			'Units' => $uom
		),
		$dimensions
	);
	$x++;
}
);

$x = 0;
foreach($pkg_values as $pkg) {
	if($pkg['PackageWeight']['UnitOfMeasurement']['Code'] == "LBS"){
		$uom = "LB";
	} else {
		$uom = $pkg["PackageWeight"]["UnitOfMeasurement"]['Code'];
	}
	if(is_array($pkg['Dimensions'])){
		$dimensions = array("Dimensions"=>array(
			'Length' => $pkg['Dimensions']['Length'],
			'Width' => $pkg['Dimensions']['Width'],
			'Height' => $pkg['Dimensions']['Height'],
			'Units' => $pkg['Dimensions']['UnitOfMeasurement']['Code'])
		);
	}

	$packageLineItem[$x] = array(
		'SequenceNumber'=>$x+1,
		'GroupPackageCount'=>1,
		'Weight' => array(
			'Value' => $pkg['PackageWeight']['Weight'],
			'Units' => $uom
		),
		$dimensions
	);
	$x++;
}
);

}
if(($this->freight==true && $this->classicMethod==false) || ($heavyProduct==true && $this->freight==true))
	$data['XMLpackage'].=$this->_createPackage($data, $product, $rate, $order );
else
	$data['XMLpackage'].=$this->_createPackage($data, $product, $rate, $order, true );

	if(($this->freight==true && $this->classicMethod==false) || ($heavyProduct==true && $this->freight==true))
		$data['XMLpackage'].=$this->_createPackage($data, $product, $rate, $order );
	else
		$data['XMLpackage'].=$this->_createPackage($data, $product, $rate, $order, true );
}

Thanks Mohamed. Your solution is almost identical to mine except that you're setting your 'SequenceNumber' => $x+1 where I set it just to $x. The sequence number starting at 0 instead of 1 seems to work fine with FedEx.

The other issue this doesn't address is the proper use of the 'GroupPackageCount' variable. The FedEx tech support person explained it to me this way. If you have 2 or 3 identical packages (same weight, same dimensions), these would normally be referenced in the same SequenceNumber as GroupPackageCount = 2 or 3 respectively. I haven't seen any other logic in the plugin that would support this. But just saying this is how the GroupPackageCount value is used and with it set to '1' as a constant, the addPackageLineItem method is not able to support proper use of the GroupPackageCount feature.

Hello,

The sequence number starting at 0 instead of 1 seems to work fine with FedEx.

The other issue this doesn't address is the proper use of the 'GroupPackageCount' variable. The FedEx tech support person explained it to me this way. If you have 2 or 3 identical packages (same weight, same dimensions), these would normally be referenced in the same SequenceNumber as GroupPackageCount = 2 or 3 respectively