Discount applied without TAX but set to with TAX

-- HikaShop version -- : HikaShop [1404122243]
-- Joomla version -- : 3.3.3
-- PHP version -- : 5.4.16

Hi,

When using a discount coupon, it's using the price without tax to calculate the discount. I've set the 'Apply discount' in TAX to with TAX but it doesn't seem to make any difference. The prices are noted as TAX included and the total is also TAX included.

I've included two images, the first one is the coupon TAX switch set to include.
The other is the cart total, the discount (excl TAX which should be incl TAX), the shipping costs, the TAX which was applied on the cart total and shipping already and finally the total cost.
The coupon had a 50% discount which should result in:
24.08 * 0.50 = 12.04 discount
However it calculates it like:
24.08 / 1.21 = 19.90 > product without TAX
19.90 * 0.50 = 9.95 discount

Thanks,
Jasper

I've been searching around and debugging the coupon code of the component.
So far I seem to have found a spot to solve my problem, however I doubt that it's the correct solution to this problem.
This is what I changed:
Line 356 and 389 in com_hikashop/classes/discount.php

$coupon->discount_flat_amount += ($coupon->discount_percent_amount * $product->prices[0]->price_value_with_tax) / 100;

$coupon->discount_flat_amount += ($coupon->discount_percent_amount * $product->prices[0]->price_value) / 100;

Oh, no, I'm using HikaShop 2.3.0. It might've been fixed in a later update but
I'm not sure if I can safely update so for now I'll just go with the edit I made
and experiment with updating on the development server.

I've set the product tax category correct so that should work,
however it makes no difference. The tax is still excluded from the discount.

Thanks,
Jasper

Hi,

Yes please try to update before.

Hi

I have something like this in the calculation of taxes and discounts problem.

1. I require that the discount is calculated the subtotal without tax, and resting the same before calculating the tax. ie:

Subtotal excluding VAT Bs. 52.124,82 - Coupon Bs.-18.243,00
Subtotal discount = Bs. 33.881,82
12% VAT Bs.4.065,82
Total Bs.37.947,63

and the shipping cost will be added to the grand total

Attached as I currently displayed.

2. I require to display in all, in the invoice, the cart, and the order.

Attachment image as shown.

We had already made a change to the invoice will show the subtotal before VAT, but with the discount calculation is wrong.

Help me ... Thanks.

Hi Nicolas
Thank you for your prompt reply, yes, I see the calculations good , but views I need appear the unit prices without tax, and also in the discount, and require that appears same in all views.

Thank you

Hi Folks,
Joomla 3.3
HiksShop Essential 234

I have the problem that others have had that in the confirmation email it shows VAT in the total while showing GST for the tax. I have tried all of the combinations in the tax setup but it hasn't changed. How do I fix this. Also I wish to change the PAY NOW link on the email. Where do I do this?

Many thanks