[SOLVED] Not defined variants returns free product

Given that you have two characteristics:

#1 Color: Blue, Red
#2 Size: Small, Big

And you have a Product in tree variants:

#1 Product: Blue, Small
#2 Product: Blue, Big
#3 Product: Red, Big

There is something that i think is a problem:

#4 Product: Red, Small is going to be selectable on product page tough it does not actually exists.

I can live with the fact that the variant can be selectable but there's something that i don't understand:

• The price of that selection (Product: Red, Small in this case) is set to "Free" as default thus creating confusion in the user.
  This can be edited in the language file with changing the "free" field with "The variant you selected is not available" and with some explanation on the product description you can overcome (partially) this situation but this modification means that you're not going to be able to have free products anymore

Hi,

You could edit the view "product / listing_price" and add a check on the variable: "$this->row->product_published".
For example:

if($this->row->product_published == 0){ echo JText::_('NOT_ON_SALE'); ?>

This can be an excellent solution.
Could you please help me understanding where exactly in the view "product/listing_price" file should i add the line of code you suggest.
That file is pretty complex.
I don't want to mess everything up.

Thanks in advance

At the top of the file, replace the lines:

  if(empty($this->row->prices)){
    echo JText::_('FREE_PRICE');
  }else{

  if($this->row->product_published == 0){ 
       echo JText::_('NOT_ON_SALE')
  }
  elseif(empty($this->row->prices)){
    echo JText::_('FREE_PRICE');
  }else{

You're awesome.
Thanks a lot.

Excuse me, don't know why but it is not working.

First let me make a little mistake in the code you gave me, there was a semicolon missing at the end of ('NOT_ON_SALE')

so the right one should be:

  if($this->row->product_published == 0){ 
       echo JText::_('NOT_ON_SALE');
  }
  elseif(empty($this->row->prices)){
    echo JText::_('FREE_PRICE');
  }else{

Hi,

My apologize, for the variants you have to edit the view "product / quantity" and replace the line:

echo JText::_('NO_STOCK');

$productClass = hikashop_get('class.product');
$variant = $productClass->get($this->row->product_id);
if(isset($variant->product_published) && $variant->product_published == 0 && !empty($this->row->characteristics)){
	echo JText::_('NOT_AVAILABLE');
}else{
        echo JText::_('NO_STOCK');
}

should i left the mods i made on the product_price view file?

You can remove the previous modifications. It wasn't useful in that case :/

nope, not working.
I've just got a subscription to the business version, i will update and then we continue talking about this in some minutes, i can send you a PM with access to the front end so you can see what i'm experiencing.

See you later.

No problem, i can wait 'till Monday.
Thanks.

Hi,

I tried the solution given again, and for me when a variant is not enabled, the message "Not available" is displayed instead of "No stock".

Could you give us a front & back end access ?

Hi Xavier, i have sent you a PM with access to the website.

This is my csv

Hi,

Ok I see from where come the problem.
I was thinking that the variants not available were unpublished, and not "not present" in your shop.

If you only unpublish the variant the modification given should work fine.
Tomorrow I will find another solution to your problem.

yes, i prefer to wait.
because i have created two characteristic for the whole international category, one for the volume in Lt. of the package and another one for the color palette of that brand, if i simply create all possible variants and then deactivate those ones i don't need my csv's are going to be ten times bigger and mainly full of unavailable variants, and that add a lot of unnecessary data on the database.

I'm following for your answer, I'm preparing a product import for around 5K products and i need to define the characteristics the most efficient and generalist possibly so i can use them in more than one product category and this situation of the non available characteristics is going to happen very frequently.

Have a good day and thanks again for your support.

Hi,

Hope this time it's the good solution

Try to replace the code:

echo JText::_('NO_STOCK');

					if(!isset($variant))
						echo JText::_('NOT_AVAILABLE');
					else
						echo JText::_('NO_STOCK');

Hi Xavier,

The code is not exactly as you write it, it should be:

if(!isset($variant))
	echo JText::_('PRODUCT_NOT_AVAILABLE');
else
	echo JText::_('NO_STOCK');

Hi,

In catalog mode, the view "product / quantity" is loaded.
Try to add the code:

if($this->row->product_published != 1){echo "Not Available";}

Did you receive the PM with the access to my backend?

Whatever, i'll be making this mods in the afternoon, i'll be back to you then.