External image

  • Posts: 567
  • Thank you received: 11
1 year 9 months ago #351360

-- HikaShop version -- : 4.3.0
-- Joomla version -- : 3.9.21
-- PHP version -- : 7.4.33
-- Browser(s) name and version -- : chrome

This message contains confidential information



Can help to check for the image display when is using the external url for image, it will append the domain name and make the image of the url cannot readable in email.

Attachments:
Last edit: 1 year 9 months ago by Philip.

Please Log in or Create an account to join the conversation.

  • Posts: 4781
  • Thank you received: 649
  • MODERATOR
1 year 9 months ago #351361

Hello,

Can you provide your relative image url please? Because it seems that your already provided url isn't correct, at least the link didn't work.
Can you provide too and url link to the relative page in order to better understand the context.
Regards

Last edit: 1 year 9 months ago by Philip.

Please Log in or Create an account to join the conversation.

  • Posts: 567
  • Thank you received: 11
1 year 9 months ago #351400

This message contains confidential information

Please Log in or Create an account to join the conversation.

  • Posts: 83326
  • Thank you received: 13473
  • MODERATOR
1 year 9 months ago #351402

Hi,

Thank you.
I was able to reproduce the issue and added a patch on our end for it.
Download again the install package of HikaShop on our website and install it on yours and you'll get the patch.

Please Log in or Create an account to join the conversation.

  • Posts: 567
  • Thank you received: 11
1 year 9 months ago #351403

can you let me know where is the patch code, because i can't directly upload the patch hikashop file

Please Log in or Create an account to join the conversation.

  • Posts: 83326
  • Thank you received: 13473
  • MODERATOR
1 year 9 months ago #351405

Hi,

The patch is not in one file. It's in each "preload" of the emails. And it's not just one line but a whole bunch, and the change is not necessarily the same in each email.
So here is a diff file of what I changed.

File Attachment:

File Name: external_i...ails.zip
File Size:1 KB

It's a text file inside a zip. So once you unzip it, you can open it with a text editor, or even better, with a tool like TortoiseUDiff
As an example, I changed the code:
else
					$image = substr(HIKASHOP_LIVE, 0, strpos(HIKASHOP_LIVE, '/', 9)) . $img->url;
to:
elseif(!$img->external)
					$image = substr(HIKASHOP_LIVE, 0, strpos(HIKASHOP_LIVE, '/', 9)) . $img->url;
				else
					$image = $img->url;
in the preload of the order status notification email.

Attachments:
Last edit: 1 year 9 months ago by nicolas.
The following user(s) said Thank You: ler@singmuiheng.com

Please Log in or Create an account to join the conversation.

Time to create page: 0.046 seconds
Powered by Kunena Forum